Issue 8495035: Make ConnectionToClient and ClientSession not ref-counted.

Issue 8495035: Make ConnectionToClient and ClientSession not ref-counted. (Closed)

Created:
9 years, 1 month ago by Sergey Ulanov

Modified:
9 years, 1 month ago

Reviewers:
Wez

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, Paweł Hajdan Jr., dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Make ConnectionToClient and ClientSession not ref-counted. Also made then NonThreadSafe. BUG=96325 TEST=Chromoting works. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109574

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Total comments: 8

Patch Set 4 : - #

Patch Set 5 : - #

Patch Set 6 : - #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -119 lines)			Patch
M	remoting/host/chromoting_host.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	remoting/host/chromoting_host.cc	View	1 2 3 4	6 chunks	+7 lines, -7 lines	0 comments	Download
M	remoting/host/chromoting_host_unittest.cc	View	1 2 3 4 5	12 chunks	+61 lines, -40 lines	0 comments	Download
M	remoting/host/client_session.h	View	1 2 3	5 chunks	+6 lines, -6 lines	0 comments	Download
M	remoting/host/client_session.cc	View	1 2 3	11 chunks	+23 lines, -4 lines	0 comments	Download
M	remoting/host/client_session_unittest.cc	View	1 2 3	2 chunks	+5 lines, -6 lines	0 comments	Download
M	remoting/host/screen_recorder.h	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	remoting/host/screen_recorder.cc	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	remoting/host/screen_recorder_unittest.cc	View	1 2 3	5 chunks	+9 lines, -7 lines	0 comments	Download
M	remoting/protocol/connection_to_client.h	View	1 2 3 4	5 chunks	+9 lines, -19 lines	0 comments	Download
M	remoting/protocol/connection_to_client.cc	View	1 2 3	7 chunks	+24 lines, -13 lines	0 comments	Download
M	remoting/protocol/connection_to_client_unittest.cc	View	1 2 3	3 chunks	+4 lines, -5 lines	0 comments	Download
M	remoting/protocol/jingle_session_unittest.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	remoting/protocol/protocol_mock_objects.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Wez

LGTM! :D http://codereview.chromium.org/8495035/diff/4001/remoting/host/chromoting_host.cc File remoting/host/chromoting_host.cc (right): http://codereview.chromium.org/8495035/diff/4001/remoting/host/chromoting_host.cc#newcode220 remoting/host/chromoting_host.cc:220: scoped_ptr<ClientSession> client_destoyer(client); typo: destoyer http://codereview.chromium.org/8495035/diff/4001/remoting/host/chromoting_host_unittest.cc File remoting/host/chromoting_host_unittest.cc ...

9 years, 1 month ago (2011-11-09 23:07:39 UTC) #2

Sergey Ulanov

http://codereview.chromium.org/8495035/diff/4001/remoting/host/chromoting_host.cc File remoting/host/chromoting_host.cc (right): http://codereview.chromium.org/8495035/diff/4001/remoting/host/chromoting_host.cc#newcode220 remoting/host/chromoting_host.cc:220: scoped_ptr<ClientSession> client_destoyer(client); On 2011/11/09 23:07:39, Wez wrote: > typo: ...

9 years, 1 month ago (2011-11-10 22:11:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8495035/15001

9 years, 1 month ago (2011-11-11 02:34:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/8495035/16015

9 years, 1 month ago (2011-11-11 02:36:08 UTC) #5

Change committed as 109574

Expand Messages | Collapse Messages