Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issue 8494013: Blacklist .diff and .patch files (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
9 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, ensonic
Visibility:
Public.

Description

Blacklist .diff and .patch files Otherwise, silly checks like EOL whitespace triggers constantly. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M presubmit_support.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
Here is an example where it is annoying: http://codereview.chromium.org/8438070/
9 years, 1 month ago (2011-11-07 18:08:09 UTC) #1
Dirk Pranke
lgtm
9 years, 1 month ago (2011-11-07 20:19:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8494013/1
9 years, 1 month ago (2011-11-07 20:20:12 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-07 20:26:22 UTC) #4
Change committed as 108899

Powered by Google App Engine
This is Rietveld 408576698