presubmit_support.py - Issue 8494013: Blacklist .diff and .patch files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: presubmit_support.py

Issue 8494013: Blacklist .diff and .patch files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: presubmit_support.py

diff --git a/presubmit_support.py b/presubmit_support.py

index 0efaca1c8dea2dff36bdea85e50857992f783b33..b2a94bc24b9b6f53a453cc98c4ede8295104a198 100755

--- a/presubmit_support.py

+++ b/presubmit_support.py

@@ -216,6 +216,9 @@ class InputApi(object):

# SCM (can happen in dual SCM configuration). (Slightly over aggressive)

r"(|.*[\\\/])\.git[\\\/].*",

r"(|.*[\\\/])\.svn[\\\/].*",

+ # There is no point in processing a patch file.

+ r".+\.diff$",

+ r".+\.patch$",

)

def __init__(self, change, presubmit_path, is_committing,

« no previous file with comments | « no previous file | tests/presubmit_unittest.py » ('j') | no next file with comments »