Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 8491056: Fix frame_rate_tests for Vista. (Closed)

Created:
9 years, 1 month ago by jbates
Modified:
9 years, 1 month ago
Reviewers:
nduca
CC:
chromium-reviews, kerz_chromium
Visibility:
Public.

Description

Fix frame_rate_tests for Vista. chrome on Vista uses accelerated canvas even without accelerated compositing. So to force software, we need --disable-accelerated-2d-canvas. Additionally, to avoid potential flakiness, moved the check from context creation success to actual swap buffers - that way if someone creates a context without drawing, it will not trigger. BUG=103956 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/test/perf/frame_rate/frame_rate_tests.cc View 2 chunks +2 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jbates
9 years, 1 month ago (2011-11-11 23:02:13 UTC) #1
nduca
lgtm How did this not pop on the other platforms?
9 years, 1 month ago (2011-11-11 23:04:14 UTC) #2
jbates
9 years, 1 month ago (2011-11-11 23:07:43 UTC) #3
On 2011/11/11 23:04:14, nduca wrote:
> lgtm
> 
> How did this not pop on the other platforms?

No clue. Still need to look into it.

Powered by Google App Engine
This is Rietveld 408576698