Issue 8491048: Fixed crash in the proxy. Reference has been passed between threads,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8491048: Fixed crash in the proxy. Reference has been passed between threads, (Closed)

Created:
9 years, 1 month ago by gene

Modified:
9 years, 1 month ago

Reviewers:
Albert Bodenhamer

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed crash in the proxy. Reference has been passed between threads, while object has been created on the stack of the first thread. Removed backend-frontend communication as it is not needed. BUG=103769 TEST=Verify GCP connector is running fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109665

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -47 lines)			Patch
M	chrome/service/cloud_print/cloud_print_connector.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/service/cloud_print/cloud_print_connector.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/service/cloud_print/cloud_print_proxy_backend.cc	View	5 chunks	+0 lines, -29 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages