Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3187)

Unified Diff: chrome/service/cloud_print/cloud_print_proxy_backend.cc

Issue 8491048: Fixed crash in the proxy. Reference has been passed between threads, (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/cloud_print/cloud_print_proxy_backend.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/cloud_print/cloud_print_proxy_backend.cc
===================================================================
--- chrome/service/cloud_print/cloud_print_proxy_backend.cc (revision 108685)
+++ chrome/service/cloud_print/cloud_print_proxy_backend.cc (working copy)
@@ -82,7 +82,6 @@
virtual void OnInvalidCredentials();
// CloudPrintConnector::Client implementation.
- virtual void OnPrintersAvailable(const printing::PrinterList& printers);
virtual void OnAuthFailed();
// notifier::TalkMediator::Delegate implementation.
@@ -239,15 +238,6 @@
core_ = NULL; // Releases reference to core_.
}
-void CloudPrintProxyBackend::RegisterPrinters(
- const printing::PrinterList& printer_list) {
- core_thread_.message_loop()->PostTask(FROM_HERE,
- NewRunnableMethod(
- core_.get(),
- &CloudPrintProxyBackend::Core::DoRegisterSelectedPrinters,
- printer_list));
-}
-
CloudPrintProxyBackend::Core::Core(
CloudPrintProxyBackend* backend,
const std::string& proxy_id,
@@ -351,13 +341,6 @@
&Core::NotifyAuthenticationFailed));
}
-void CloudPrintProxyBackend::Core::OnPrintersAvailable(
- const printing::PrinterList& printers) {
- // Let the frontend know that we have a list of printers available.
- backend_->frontend_loop_->PostTask(FROM_HERE, NewRunnableMethod(this,
- &Core::NotifyPrinterListAvailable, printers));
-}
-
void CloudPrintProxyBackend::Core::OnAuthFailed() {
VLOG(1) << "CP_CONNECTOR: Authentication failed in connector.";
// Let's stop connecter and refresh token. We'll restart connecter once
@@ -406,12 +389,6 @@
token_store_.reset();
}
-void CloudPrintProxyBackend::Core::DoRegisterSelectedPrinters(
- const printing::PrinterList& printer_list) {
- DCHECK(MessageLoop::current() == backend_->core_thread_.message_loop());
- connector_->RegisterPrinters(printer_list);
-}
-
void CloudPrintProxyBackend::Core::HandlePrinterNotification(
const std::string& printer_id) {
DCHECK(MessageLoop::current() == backend_->core_thread_.message_loop());
@@ -451,12 +428,6 @@
return token_store_.get();
}
-void CloudPrintProxyBackend::Core::NotifyPrinterListAvailable(
- const printing::PrinterList& printer_list) {
- DCHECK(MessageLoop::current() == backend_->frontend_loop_);
- backend_->frontend_->OnPrinterListAvailable(printer_list);
-}
-
void CloudPrintProxyBackend::Core::NotifyAuthenticated(
const std::string& robot_oauth_refresh_token,
const std::string& robot_email,
« no previous file with comments | « chrome/service/cloud_print/cloud_print_proxy_backend.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698