Issue 8491035: Revert 109583 - Move views/ime/text_input_client.h to ui/base/ime/.

Issue 8491035: Revert 109583 - Move views/ime/text_input_client.h to ui/base/ime/. (Closed)

Created:
9 years, 1 month ago by Yusuke Sato

Modified:
9 years, 1 month ago

Reviewers:
Yusuke (unused)

CC:
chromium-reviews, tfarina, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., James Su, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 109583 - Move views/ime/text_input_client.h to ui/base/ime/. - Remove Views dependencies from text_input_client.h. - Change namespace from views:: to ui::. This change is necessary for RenderWidgetHostViewAura to support IME since RWHVA is Views agnostic and cannot directly use classes under views/ime/. BUG=chromium:97261 TEST=try Review URL: http://codereview.chromium.org/8509034 TBR=yusukes@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109586

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -187 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_views.h	View	4 chunks	+5 lines, -4 lines	0 comments	Download
MM	chrome/browser/renderer_host/render_widget_host_view_views.cc	View	3 chunks	+6 lines, -2 lines	0 comments	Download
D	ui/base/ime/text_input_client.h	View	1 chunk	+0 lines, -119 lines	0 comments	Download
M	ui/ui.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_gtk.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_gtk.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_views.h	View	6 chunks	+5 lines, -4 lines	0 comments	Download
M	views/controls/textfield/native_textfield_views.cc	View	3 chunks	+6 lines, -2 lines	0 comments	Download
MM	views/controls/textfield/native_textfield_views_unittest.cc	View	4 chunks	+3 lines, -3 lines	0 comments	Download
M	views/controls/textfield/native_textfield_win.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_wrapper.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/controls/textfield/textfield.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	views/controls/textfield/textfield.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/ime/input_method.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	views/ime/input_method_base.h	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	views/ime/input_method_base.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	views/ime/input_method_gtk.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	views/ime/input_method_gtk.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	views/ime/input_method_ibus.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	views/ime/input_method_ibus.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	views/ime/input_method_wayland.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/ime/input_method_win.cc	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	views/ime/mock_input_method.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	views/ime/mock_input_method.cc	View	3 chunks	+2 lines, -3 lines	0 comments	Download
A +	views/ime/text_input_client.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	views/view.h	View	3 chunks	+2 lines, -2 lines	0 comments	Download
M	views/view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	views/views.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages