Issue 8509034: Move views/ime/text_input_client.h to ui/base/ime/.

Issue 8509034: Move views/ime/text_input_client.h to ui/base/ime/. (Closed)

Created:
9 years, 1 month ago by Yusuke Sato

Modified:
9 years, 1 month ago

Reviewers:
mazda, James Su, sky

CC:
chromium-reviews, tfarina, brettw-cc_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., James Su, dhollowa, Emmanuel Saint-loubert-Bié

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Move views/ime/text_input_client.h to ui/base/ime/. - Remove Views dependencies from text_input_client.h. - Change namespace from views:: to ui::. This change is necessary for RenderWidgetHostViewAura to support IME since RWHVA is Views agnostic and cannot directly use classes under views/ime/. BUG=chromium:97261 TEST=try Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109583 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109608

Patch Set 1 : review #

Total comments: 4

Patch Set 2 : review fix #

Patch Set 3 : add deps to chrome_browser.gypi #

Patch Set 4 : more win_shared fix #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -199 lines)			Patch
M	chrome/browser/renderer_host/render_widget_host_view_views.h	View	1	4 chunks	+4 lines, -5 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_views.cc	View		3 chunks	+2 lines, -6 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A +	ui/base/ime/text_input_client.h	View	1 2 3	2 chunks	+9 lines, -15 lines	0 comments	Download
A	ui/base/ime/text_input_client.cc	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/controls/textfield/native_textfield_gtk.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_gtk.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_views.h	View		6 chunks	+4 lines, -5 lines	0 comments	Download
M	views/controls/textfield/native_textfield_views.cc	View		3 chunks	+2 lines, -6 lines	0 comments	Download
M	views/controls/textfield/native_textfield_views_unittest.cc	View		4 chunks	+3 lines, -3 lines	0 comments	Download
M	views/controls/textfield/native_textfield_win.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/controls/textfield/native_textfield_wrapper.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	views/controls/textfield/textfield.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	views/controls/textfield/textfield.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/ime/input_method.h	View		3 chunks	+5 lines, -2 lines	0 comments	Download
M	views/ime/input_method_base.h	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
M	views/ime/input_method_base.cc	View	1	4 chunks	+5 lines, -4 lines	0 comments	Download
M	views/ime/input_method_gtk.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/ime/input_method_gtk.cc	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	views/ime/input_method_ibus.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	views/ime/input_method_ibus.cc	View	1	5 chunks	+5 lines, -5 lines	0 comments	Download
M	views/ime/input_method_wayland.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/ime/input_method_win.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	views/ime/mock_input_method.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	views/ime/mock_input_method.cc	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
D	views/ime/text_input_client.h	View		1 chunk	+0 lines, -125 lines	0 comments	Download
M	views/view.h	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	views/view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	views/views.gyp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/8509034/diff/3028/chrome/browser/renderer_host/render_widget_host_view_views.h File chrome/browser/renderer_host/render_widget_host_view_views.h (right): http://codereview.chromium.org/8509034/diff/3028/chrome/browser/renderer_host/render_widget_host_view_views.h#newcode24 chrome/browser/renderer_host/render_widget_host_view_views.h:24: #include "ui/base/ime/text_input_client.h" sort http://codereview.chromium.org/8509034/diff/3028/views/ime/input_method_ibus.h File views/ime/input_method_ibus.h (right): http://codereview.chromium.org/8509034/diff/3028/views/ime/input_method_ibus.h#newcode21 ...

9 years, 1 month ago (2011-11-10 16:04:50 UTC) #4

Yusuke Sato

http://codereview.chromium.org/8509034/diff/3028/chrome/browser/renderer_host/render_widget_host_view_views.h File chrome/browser/renderer_host/render_widget_host_view_views.h (right): http://codereview.chromium.org/8509034/diff/3028/chrome/browser/renderer_host/render_widget_host_view_views.h#newcode24 chrome/browser/renderer_host/render_widget_host_view_views.h:24: #include "ui/base/ime/text_input_client.h" On 2011/11/10 16:04:51, sky wrote: > sort ...

9 years, 1 month ago (2011-11-11 02:18:25 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8509034/11001

9 years, 1 month ago (2011-11-11 02:18:45 UTC) #6

commit-bot: I haz the power

Try job failure for 8509034-11001 (retry) on mac_rel for step "ui_tests". It's a second try, ...

9 years, 1 month ago (2011-11-11 04:11:04 UTC) #7

Yusuke Sato

It turned out that Patch Set 2 was not good enough; it broke win_shared builder. ...

9 years, 1 month ago (2011-11-11 07:09:05 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/8509034/17001

9 years, 1 month ago (2011-11-11 08:57:51 UTC) #10

Change committed as 109608

Expand Messages | Collapse Messages