src/property.h - Issue 8491016: Refactoring only: Make the handling of PropertyType more explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/property.h

Issue 8491016: Refactoring only: Make the handling of PropertyType more explicit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Unified our 2 UpdateCaches implementations, making some assumptions more explicit Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/property.h

diff --git a/src/property.h b/src/property.h

index ffea41e66688ae46af057dc51736f0bad54384c1..133abc1b42ef0bd50e307485f5e0f7cc3fb7a300 100644

--- a/src/property.h

+++ b/src/property.h

@@ -292,10 +292,10 @@ class LookupResult BASE_EMBEDDED {

}

Map* GetTransitionMap() {

ASSERT(lookup_type_ == DESCRIPTOR_TYPE);

- ASSERT(type() == MAP_TRANSITION || type() == CONSTANT_TRANSITION ||

- type() == ELEMENTS_TRANSITION);

+ ASSERT(IsTransitionType(type()));

return Map::cast(GetValue());

}

« no previous file with comments | « src/objects-printer.cc ('k') | src/runtime.cc » ('j') | no next file with comments »