src/runtime.cc - Issue 8491016: Refactoring only: Make the handling of PropertyType more explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 8491016: Refactoring only: Make the handling of PropertyType more explicit. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Unified our 2 UpdateCaches implementations, making some assumptions more explicit Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index 29807da9f296e3e5e4bf33a89fa329793fffac0d..c1a87dbf824f4721f0e6a64031fcc4ca922b68d3 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -10406,10 +10406,11 @@ static MaybeObject* DebugLookupResultValue(Heap* heap,

case CONSTANT_TRANSITION:

case NULL_DESCRIPTOR:

return heap->undefined_value();

- default:

+ case HANDLER:

UNREACHABLE();

+ return heap->undefined_value();

}

- UNREACHABLE();

+ UNREACHABLE(); // keep the compiler happy

return heap->undefined_value();

}

« no previous file with comments | « src/property.h ('k') | src/v8globals.h » ('j') | no next file with comments »