Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autofill/autofill_manager.h

Index: chrome/browser/autofill/autofill_manager.h
diff --git a/chrome/browser/autofill/autofill_manager.h b/chrome/browser/autofill/autofill_manager.h
index 4115187595fbdc0b1ffb6f53b0d90c6dae36f418..64d8b5d3b9a5621e1f9d1b41d9c9328e76838b07 100644
--- a/chrome/browser/autofill/autofill_manager.h
+++ b/chrome/browser/autofill/autofill_manager.h
@@ -23,6 +23,7 @@
 #include "chrome/browser/autofill/field_types.h"
 #include "chrome/browser/autofill/form_structure.h"
 #include "content/browser/tab_contents/tab_contents_observer.h"
+#include "ui/gfx/rect.h"

[Ilya Sherman, 2011/11/09 20:34:19]

nit: Let's forward-declare gfx::Rect here and move the #include to the
implementation file.

[csharp, 2011/11/10 18:09:32]

Done.

 
 class AutofillExternalDelegate;
 class AutofillField;
@@ -143,9 +144,12 @@ class AutofillManager : public TabContentsObserver,
   void OnTextFieldDidChange(const webkit_glue::FormData& form,
                             const webkit_glue::FormField& field,
                             const base::TimeTicks& timestamp);
+
+  // The bounding_box is a page_relative value.

[Ilya Sherman, 2011/11/09 20:34:19]

nit: "bounding_box" -> "|bounding_box|"

[John Grabowski, 2011/11/09 22:18:34]

page_relative --> page relative (is english)

[csharp, 2011/11/10 18:09:32]

Done.

   void OnQueryFormFieldAutofill(int query_id,
                                 const webkit_glue::FormData& form,
-                                const webkit_glue::FormField& field);
+                                const webkit_glue::FormField& field,
+                                const gfx::Rect& bounding_box);
   void OnFillAutofillFormData(int query_id,
                               const webkit_glue::FormData& form,
                               const webkit_glue::FormField& field,
@@ -154,6 +158,7 @@ class AutofillManager : public TabContentsObserver,
   void OnDidPreviewAutofillFormData();
   void OnDidFillAutofillFormData(const base::TimeTicks& timestamp);
   void OnDidShowAutofillSuggestions(bool is_new_popup);
+  void OnHideAutofillPopup();
 
   // Fills |host| with the RenderViewHost for this tab.
   // Returns false if Autofill is disabled or if the host is unavailable.