Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autofill/autofill_manager.cc

Index: chrome/browser/autofill/autofill_manager.cc
diff --git a/chrome/browser/autofill/autofill_manager.cc b/chrome/browser/autofill/autofill_manager.cc
index 575407d0fee0a9ecc63fb11c4017d4ca4041cd4b..227c9870243ad167bc5889485c62bd763b672dd9 100644
--- a/chrome/browser/autofill/autofill_manager.cc
+++ b/chrome/browser/autofill/autofill_manager.cc
@@ -311,6 +311,8 @@ bool AutofillManager::OnMessageReceived(const IPC::Message& message) {
                         OnDidFillAutofillFormData)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_DidShowAutofillSuggestions,
                         OnDidShowAutofillSuggestions)
+    IPC_MESSAGE_HANDLER(AutofillHostMsg_HideAutofillPopup,
+                        OnHideAutofillPopup)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
 
@@ -439,14 +441,17 @@ void AutofillManager::OnTextFieldDidChange(const FormData& form,
 
 void AutofillManager::OnQueryFormFieldAutofill(int query_id,
                                                const FormData& form,
-                                               const FormField& field) {
+                                               const FormField& field,
+                                               const gfx::Rect& bounding_box) {
   std::vector<string16> values;
   std::vector<string16> labels;
   std::vector<string16> icons;
   std::vector<int> unique_ids;
 
-  if (external_delegate_)
+  if (external_delegate_) {
     external_delegate_->OnQuery(query_id, form, field);
+    external_delegate_->SetAutofillElementBounds(bounding_box);

[Ilya Sherman, 2011/11/09 20:34:19]

nit: Are you sure you want these to be two separate methods?  Would they ever be
called separately?

[csharp, 2011/11/10 18:09:32]

Hmmm, I don't think we would need to call them separately at any time, assuming
that we hide the popup any time the page moves like we currently do,  so I'll
merge them.

On 2011/11/09 20:34:19, Ilya Sherman wrote:

+  }
 
   RenderViewHost* host = NULL;
   FormStructure* form_structure = NULL;
@@ -673,6 +678,11 @@ void AutofillManager::OnDidShowAutofillSuggestions(bool is_new_popup) {
   }
 }
 
+void AutofillManager::OnHideAutofillPopup() {
+  if (external_delegate_)
+    external_delegate_->HideAutofillPopup();
+}
+
 void AutofillManager::OnLoadedServerPredictions(
     const std::string& response_xml) {
   // Parse and store the server predictions.