Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autocomplete_history_manager.cc

Index: chrome/browser/autocomplete_history_manager.cc
diff --git a/chrome/browser/autocomplete_history_manager.cc b/chrome/browser/autocomplete_history_manager.cc
index ea4e3998508430f7b54a7cb95ef8d17d876db979..9bae7c56a7859eb42dcb7d22fb91bde760fa00e3 100644
--- a/chrome/browser/autocomplete_history_manager.cc
+++ b/chrome/browser/autocomplete_history_manager.cc
@@ -265,6 +265,7 @@ void AutocompleteHistoryManager::SendSuggestions(
   }
 
   if (external_delegate_) {
+    Send(new AutofillMsg_HasExternalDelegate(routing_id(), true));

[Ilya Sherman, 2011/11/07 21:48:49]

How about instead calling this within AutofillManager::SetExternalDelegate()?

[csharp1, 2011/11/08 19:59:00]

That doesn't seem to work. Although the Send function does return true when
calling from SetExternalDelegate, Autofill_Agent does not seem to get the
message. I think this might happen because when we assign the delegate,
autofill_agent isn't yet initialized.

On 2011/11/07 21:48:49, Ilya Sherman wrote:

[Ilya Sherman, 2011/11/08 21:06:16]

Ah, that's irksome.  Now that I think about this a bit more, though... do we
even need to tell the AutofillAgent that there's an external delegate?  When
there is an external delegate, the browser process can avoid ever calling into
AutofillAgent::OnSuggestionsReturned().  Within
AutofillAgent::InputElementLostFocus(), the renderer can just always send the
HideAutofillPopup message -- the AutofillManager can disregard any such message
if it doesn't have an external delegate.

On 2011/11/08 19:59:00, csharp1 wrote:

[csharp, 2011/11/09 16:18:37]

Seems like a good solution, changes made.

On 2011/11/08 21:06:16, Ilya Sherman wrote:

     external_delegate_->OnSuggestionsReturned(
         query_id_,
         autofill_values_,