Setting up external delegate calls to allow a future delegate to handle autofill

chrome/browser/autocomplete_history_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete_history_manager.h"
 
 #include <vector>
 
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
@@ skipping 247 matching lines @@
       if (unique) {
         autofill_values_.push_back((*suggestions)[i]);
         autofill_labels_.push_back(string16());
         autofill_icons_.push_back(string16());
         autofill_unique_ids_.push_back(0);  // 0 means no profile.
       }
     }
   }
 
   if (external_delegate_) {
+    Send(new AutofillMsg_HasExternalDelegate(routing_id(), true));

[Ilya Sherman, 2011/11/07 21:48:49]

How about instead calling this within AutofillManager::SetExternalDelegate()?

[csharp1, 2011/11/08 19:59:00]

That doesn't seem to work. Although the Send function does return true when
calling from SetExternalDelegate, Autofill_Agent does not seem to get the
message. I think this might happen because when we assign the delegate,
autofill_agent isn't yet initialized.

On 2011/11/07 21:48:49, Ilya Sherman wrote:

[Ilya Sherman, 2011/11/08 21:06:16]

Ah, that's irksome.  Now that I think about this a bit more, though... do we
even need to tell the AutofillAgent that there's an external delegate?  When
there is an external delegate, the browser process can avoid ever calling into
AutofillAgent::OnSuggestionsReturned().  Within
AutofillAgent::InputElementLostFocus(), the renderer can just always send the
HideAutofillPopup message -- the AutofillManager can disregard any such message
if it doesn't have an external delegate.

On 2011/11/08 19:59:00, csharp1 wrote:

[csharp, 2011/11/09 16:18:37]

Seems like a good solution, changes made.

On 2011/11/08 21:06:16, Ilya Sherman wrote:

     external_delegate_->OnSuggestionsReturned(
         query_id_,
         autofill_values_,
         autofill_labels_,
         autofill_icons_,
         autofill_unique_ids_);
   }
 
   Send(new AutofillMsg_SuggestionsReturned(routing_id(),
                                            query_id_,
                                            autofill_values_,
                                            autofill_labels_,
                                            autofill_icons_,
                                            autofill_unique_ids_));
 
   query_id_ = 0;
   autofill_values_.clear();
   autofill_labels_.clear();
   autofill_icons_.clear();
   autofill_unique_ids_.clear();
 }