Fixes regression that was causing omnibox to select all when page finished

Fixes regression that was causing omnibox to select all when page finished
loading. This effectively reverts the change to LocationBar. The change to LocationBarView was problematic because the boolean passed to OmniboxView::SelectAll means something different than the boolean passed to LocationBarView::FocusLocation.

BUG=104201
TEST=see bug
R=alicet@chromium.org,ben@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110352

[Ben Goodger (Google), 2011-11-16 18:49:10]

LGTM

On Wed, Nov 16, 2011 at 10:47 AM, <sky@chromium.org> wrote:

> Reviewers: alicet1, Ben Goodger (Google),
>
> Description:
> Fixes regression that was causing omnibox to select all when page finished
> loading. This effectively reverts the change to LocationBar. The change to
> LocationBarView was problematic because the boolean passed to
> OmniboxView::SelectAll means something different than the boolean passed to
> LocationBarView::**FocusLocation.
>
> BUG=104201
> TEST=see bug
> R=alicet@chromium.org,ben@**chromium.org <ben@chromium.org>
>
>
> Please review this at
http://codereview.chromium.**org/8486022/<http://codereview.chromium.org/8486...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/ui/views/**location_bar/location_bar_**view.cc
>
>
> Index: chrome/browser/ui/views/**location_bar/location_bar_**view.cc
> diff --git a/chrome/browser/ui/views/**location_bar/location_bar_**view.cc
> b/chrome/browser/ui/views/**location_bar/location_bar_**view.cc
> index cab1b06b6eebcde69eeb28f66f1340**6af2a896a1..**
> deda11801c4daf95cdf796571504e0**87efbfa2ae 100644
> --- a/chrome/browser/ui/views/**location_bar/location_bar_**view.cc
> +++ b/chrome/browser/ui/views/**location_bar/location_bar_**view.cc
> @@ -352,7 +352,7 @@ void LocationBarView::OnFocus() {
>
>   // Then focus the native location view which implements accessibility for
>   // Windows.
> -  FocusLocation(true);
> +  location_entry_->SetFocus();
>  }
>
>  void LocationBarView::**SetPreviewEnabledPageAction(**ExtensionAction*
> page_action,
> @@ -1123,7 +1123,8 @@ void LocationBarView::AcceptInput() {
>
>  void LocationBarView::**FocusLocation(bool select_all) {
>   location_entry_->SetFocus();
> -  location_entry_->SelectAll(**select_all);
> +  if (select_all)
> +    location_entry_->SelectAll(**true);
>  }
>
>  void LocationBarView::FocusSearch() {
>
>
>

[commit-bot: I haz the power, 2011-11-16 19:13:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sky@chromium.org/8486022/1

[commit-bot: I haz the power, 2011-11-16 21:31:26]

Change committed as 110352