Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 8486022: Fixes regression that was causing omnibox to select all when page finished (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/location_bar/location_bar_view.cc
diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc
index cab1b06b6eebcde69eeb28f66f13406af2a896a1..deda11801c4daf95cdf796571504e087efbfa2ae 100644
--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc
+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc
@@ -352,7 +352,7 @@ void LocationBarView::OnFocus() {
// Then focus the native location view which implements accessibility for
// Windows.
- FocusLocation(true);
+ location_entry_->SetFocus();
}
void LocationBarView::SetPreviewEnabledPageAction(ExtensionAction* page_action,
@@ -1123,7 +1123,8 @@ void LocationBarView::AcceptInput() {
void LocationBarView::FocusLocation(bool select_all) {
location_entry_->SetFocus();
- location_entry_->SelectAll(select_all);
+ if (select_all)
+ location_entry_->SelectAll(true);
}
void LocationBarView::FocusSearch() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698