Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 848005: Fail build_autotest.sh if any test fails to build. (Closed)

Created:
10 years, 9 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, djmm
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Fail build_autotest.sh if any test fails to build. This change may be controversial -- it will basically make the x86-generic full buildbot fail if tests fail to build. There are a few options: 1. do this and see how it goes; 2. don't do this and rely on the test failing to run; 3. do this but also change buildbot to pass --nobuildcheck to build_autotest

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/scripts/build_autotest.sh View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
petkov
10 years, 9 months ago (2010-03-11 21:33:24 UTC) #1
djmm
My feeling is that the buildbots should reflect as much as the end-to-end build,test,release process ...
10 years, 9 months ago (2010-03-11 21:50:04 UTC) #2
kmixter1
10 years, 9 months ago (2010-03-12 00:53:18 UTC) #3
LGTM

On Thu, Mar 11, 2010 at 1:50 PM,  <djmm@chromium.org> wrote:
> My feeling is that the buildbots should reflect as much as the end-to-end
> build,test,release process as possible and any failure at any point should
> turn
> it red.
>
> LGTM
>
> http://codereview.chromium.org/848005
>

Powered by Google App Engine
This is Rietveld 408576698