Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6826)

Unified Diff: chrome/browser/policy/configuration_policy_handler_chromeos_unittest.cc

Issue 8480003: Surface error messages from ONC parsing in about:policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only compile unit test for chromium os. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/configuration_policy_handler_chromeos_unittest.cc
diff --git a/chrome/browser/policy/configuration_policy_handler_chromeos_unittest.cc b/chrome/browser/policy/configuration_policy_handler_chromeos_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a14769191ea8d7231dacece1d69de2732378f4f0
--- /dev/null
+++ b/chrome/browser/policy/configuration_policy_handler_chromeos_unittest.cc
@@ -0,0 +1,65 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/policy/configuration_policy_handler_chromeos.h"
+
+#include "chrome/browser/policy/policy_error_map.h"
+#include "chrome/browser/policy/policy_map.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace policy {
+
+TEST(NetworkConfigurationPolicyHandlerTest, Empty) {
+ PolicyMap policy_map;
+ NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
+ PolicyErrorMap errors;
+ EXPECT_TRUE(handler.CheckPolicySettings(&policy_map, &errors));
+ EXPECT_TRUE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
+}
+
+TEST(NetworkConfigurationPolicyHandlerTest, ValidONC) {
+ const std::string kTestONC(
+ "{"
+ " \"NetworkConfigurations\": [{"
+ " \"GUID\": \"{485d6076-dd44-6b6d-69787465725f5045}\","
+ " \"Type\": \"WiFi\","
+ " \"WiFi\": {"
+ " \"Security\": \"WEP\","
+ " \"SSID\": \"ssid\","
+ " \"Passphrase\": \"pass\","
+ " }"
+ " }]"
+ "}");
+
+ PolicyMap policy_map;
+ policy_map.Set(kPolicyOpenNetworkConfiguration,
+ Value::CreateStringValue(kTestONC));
+ NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
+ PolicyErrorMap errors;
+ EXPECT_TRUE(handler.CheckPolicySettings(&policy_map, &errors));
+ EXPECT_TRUE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
+}
+
+TEST(NetworkConfigurationPolicyHandlerTest, WrongType) {
+ PolicyMap policy_map;
+ policy_map.Set(kPolicyOpenNetworkConfiguration,
+ Value::CreateBooleanValue(false));
+ NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
+ PolicyErrorMap errors;
+ EXPECT_FALSE(handler.CheckPolicySettings(&policy_map, &errors));
+ EXPECT_FALSE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
+}
+
+TEST(NetworkConfigurationPolicyHandlerTest, JSONParseError) {
+ const std::string kTestONC("I'm not proper JSON!");
+ PolicyMap policy_map;
+ policy_map.Set(kPolicyOpenNetworkConfiguration,
+ Value::CreateStringValue(kTestONC));
+ NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
+ PolicyErrorMap errors;
+ EXPECT_FALSE(handler.CheckPolicySettings(&policy_map, &errors));
+ EXPECT_FALSE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
+}
+
+}

Powered by Google App Engine
This is Rietveld 408576698