Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: chrome/browser/policy/configuration_policy_handler_chromeos_unittest.cc

Issue 8480003: Surface error messages from ONC parsing in about:policy. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only compile unit test for chromium os. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/browser/policy/configuration_policy_handler_chromeos.h"
6
7 #include "chrome/browser/policy/policy_error_map.h"
8 #include "chrome/browser/policy/policy_map.h"
9 #include "testing/gtest/include/gtest/gtest.h"
10
11 namespace policy {
12
13 TEST(NetworkConfigurationPolicyHandlerTest, Empty) {
14 PolicyMap policy_map;
15 NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
16 PolicyErrorMap errors;
17 EXPECT_TRUE(handler.CheckPolicySettings(&policy_map, &errors));
18 EXPECT_TRUE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
19 }
20
21 TEST(NetworkConfigurationPolicyHandlerTest, ValidONC) {
22 const std::string kTestONC(
23 "{"
24 " \"NetworkConfigurations\": [{"
25 " \"GUID\": \"{485d6076-dd44-6b6d-69787465725f5045}\","
26 " \"Type\": \"WiFi\","
27 " \"WiFi\": {"
28 " \"Security\": \"WEP\","
29 " \"SSID\": \"ssid\","
30 " \"Passphrase\": \"pass\","
31 " }"
32 " }]"
33 "}");
34
35 PolicyMap policy_map;
36 policy_map.Set(kPolicyOpenNetworkConfiguration,
37 Value::CreateStringValue(kTestONC));
38 NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
39 PolicyErrorMap errors;
40 EXPECT_TRUE(handler.CheckPolicySettings(&policy_map, &errors));
41 EXPECT_TRUE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
42 }
43
44 TEST(NetworkConfigurationPolicyHandlerTest, WrongType) {
45 PolicyMap policy_map;
46 policy_map.Set(kPolicyOpenNetworkConfiguration,
47 Value::CreateBooleanValue(false));
48 NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
49 PolicyErrorMap errors;
50 EXPECT_FALSE(handler.CheckPolicySettings(&policy_map, &errors));
51 EXPECT_FALSE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
52 }
53
54 TEST(NetworkConfigurationPolicyHandlerTest, JSONParseError) {
55 const std::string kTestONC("I'm not proper JSON!");
56 PolicyMap policy_map;
57 policy_map.Set(kPolicyOpenNetworkConfiguration,
58 Value::CreateStringValue(kTestONC));
59 NetworkConfigurationPolicyHandler handler(kPolicyOpenNetworkConfiguration);
60 PolicyErrorMap errors;
61 EXPECT_FALSE(handler.CheckPolicySettings(&policy_map, &errors));
62 EXPECT_FALSE(errors.GetErrors(kPolicyOpenNetworkConfiguration).empty());
63 }
64
65 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698