UI polish for certificate viewer

chrome/browser/ui/dialog_style.h

Index: chrome/browser/ui/dialog_style.h
diff --git a/chrome/browser/ui/dialog_style.h b/chrome/browser/ui/dialog_style.h
index 31299ca1110a4ea40b752fca56b01ef15255c426..66ae5cc3c43f80f45bf1d5a74890854e95e4f2ad 100644
--- a/chrome/browser/ui/dialog_style.h
+++ b/chrome/browser/ui/dialog_style.h
@@ -25,7 +25,11 @@ enum DialogStyle {
   STYLE_THROBBER = 1 << 1,
 
   // Content flush to edge, no padding.
-  STYLE_FLUSH = 1 << 2
+  STYLE_FLUSH = 1 << 2,
+
+  // Only for certificate viewer. Add close button to the top right and fluch

[flackr, 2011/11/21 20:43:31]

The style presumably only makes the content flush to edge, but does not add a
close button. To differentiate it from STYLE_FLUSH above mention that the title
bar will still have the regular padding. Also, remove the Only for certificate
viewer comment. We were discussing with rbyers whether we could change FLUSH to
mean what we wanted. Have you checked if any dialogs that use STYLE_FLUSH also
have titles? If not we don't even have to introduce a new style for this.

[bshe, 2011/11/22 16:26:24]

Done. 

We will keep this style as extension dialog uses STYLE_FLUSH and has title.

[flackr, 2011/11/22 17:02:59]

Looks good, change this comment to padding only on title to be extra clear about
the difference.

[bshe, 2011/11/22 19:20:46]

Done.

+  // content to edge, no padding.
+  STYLE_FLUSH_CONTENT = 1 << 3
 #endif
 
 };