UI polish for certificate viewer

chrome/browser/ui/dialog_style.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_DIALOG_STYLE_H_
 #define CHROME_BROWSER_UI_DIALOG_STYLE_H_
 #pragma once
 
 #include "third_party/skia/include/core/SkColor.h"
 
 // A class to share common definitions between GTK and Views implementations.
 enum DialogStyle {
   // Default style.
   STYLE_GENERIC = 0,
 
 #if defined(OS_CHROMEOS)
   // Show close button at the top right (left for RTL).
   // Deprecated, see BubbleWindow::Create().
   // TODO(bshe): We probably need to use this style for certificate viewer
   // HTML dialog.
   STYLE_XBAR = 1 << 0,
 
   // Show throbber for slow rendering.
   // Deprecated, see BubbleWindow::Create().
   STYLE_THROBBER = 1 << 1,
 
   // Content flush to edge, no padding.
-  STYLE_FLUSH = 1 << 2
+  STYLE_FLUSH = 1 << 2,
+
+  // Only for certificate viewer. Add close button to the top right and fluch

[flackr, 2011/11/21 20:43:31]

The style presumably only makes the content flush to edge, but does not add a
close button. To differentiate it from STYLE_FLUSH above mention that the title
bar will still have the regular padding. Also, remove the Only for certificate
viewer comment. We were discussing with rbyers whether we could change FLUSH to
mean what we wanted. Have you checked if any dialogs that use STYLE_FLUSH also
have titles? If not we don't even have to introduce a new style for this.

[bshe, 2011/11/22 16:26:24]

Done. 

We will keep this style as extension dialog uses STYLE_FLUSH and has title.

[flackr, 2011/11/22 17:02:59]

Looks good, change this comment to padding only on title to be extra clear about
the difference.

[bshe, 2011/11/22 19:20:46]

Done.

+  // content to edge, no padding.
+  STYLE_FLUSH_CONTENT = 1 << 3
 #endif
 
 };
 
 #endif  // CHROME_BROWSER_UI_DIALOG_STYLE_H_