Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: content/browser/tab_contents/tab_contents_view.h

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changes for jochen and jam Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents_view.h
diff --git a/content/browser/tab_contents/tab_contents_view.h b/content/browser/tab_contents/tab_contents_view.h
index 05da7c6c8d78df9ff42cf5ea8822f121d3810192..10535ca7a661a6735a2e923f0ce70c525422a97a 100644
--- a/content/browser/tab_contents/tab_contents_view.h
+++ b/content/browser/tab_contents/tab_contents_view.h
@@ -66,8 +66,7 @@ class CONTENT_EXPORT TabContentsView : public RenderViewHostDelegate::View {
// trying to find a specific window.
virtual void SetPageTitle(const string16& title) = 0;
- // Used to notify the view that a tab has crashed so each platform can
- // prepare the sad tab.
+ // Used to notify the view that a tab has crashed.
virtual void OnTabCrashed(base::TerminationStatus status,
int error_code) = 0;
@@ -117,6 +116,18 @@ class CONTENT_EXPORT TabContentsView : public RenderViewHostDelegate::View {
// TODO(beng): Return a rect rather than using an out param.
virtual void GetViewBounds(gfx::Rect* out) const = 0;
+ // ---------------------------------------------------------------------------
+ // Functions for embedders.
+ // TODO(avi): Figure out where these go on the API surface.
+
+ // Installs a native view to cover the visible web contents. Removed by
+ // |RemoveOverlayView|. This is not a transfer of ownership, and the view must
+ // remain valid until removed.
+ virtual void InstallOverlayView(gfx::NativeView view) = 0;
+
+ // Removes the native overlay view installed by |InstallOverlayView|.
+ virtual void RemoveOverlayView() = 0;
+
protected:
TabContentsView(); // Abstract interface.
« no previous file with comments | « content/browser/tab_contents/tab_contents_observer.cc ('k') | content/browser/tab_contents/tab_contents_view_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698