Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: content/browser/tab_contents/tab_contents_view.h

Issue 8477042: Move Sad Tab implementation out of the TabContentsViews. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: changes for jochen and jam Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_ 5 #ifndef CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_
6 #define CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_ 6 #define CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 GetContainerBounds(&rc); 59 GetContainerBounds(&rc);
60 return gfx::Size(rc.width(), rc.height()); 60 return gfx::Size(rc.width(), rc.height());
61 } 61 }
62 62
63 // Sets the page title for the native widgets corresponding to the view. This 63 // Sets the page title for the native widgets corresponding to the view. This
64 // is not strictly necessary and isn't expected to be displayed anywhere, but 64 // is not strictly necessary and isn't expected to be displayed anywhere, but
65 // can aid certain debugging tools such as Spy++ on Windows where you are 65 // can aid certain debugging tools such as Spy++ on Windows where you are
66 // trying to find a specific window. 66 // trying to find a specific window.
67 virtual void SetPageTitle(const string16& title) = 0; 67 virtual void SetPageTitle(const string16& title) = 0;
68 68
69 // Used to notify the view that a tab has crashed so each platform can 69 // Used to notify the view that a tab has crashed.
70 // prepare the sad tab.
71 virtual void OnTabCrashed(base::TerminationStatus status, 70 virtual void OnTabCrashed(base::TerminationStatus status,
72 int error_code) = 0; 71 int error_code) = 0;
73 72
74 // TODO(brettw) this is a hack. It's used in two places at the time of this 73 // TODO(brettw) this is a hack. It's used in two places at the time of this
75 // writing: (1) when render view hosts switch, we need to size the replaced 74 // writing: (1) when render view hosts switch, we need to size the replaced
76 // one to be correct, since it wouldn't have known about sizes that happened 75 // one to be correct, since it wouldn't have known about sizes that happened
77 // while it was hidden; (2) in constrained windows. 76 // while it was hidden; (2) in constrained windows.
78 // 77 //
79 // (1) will be fixed once interstitials are cleaned up. (2) seems like it 78 // (1) will be fixed once interstitials are cleaned up. (2) seems like it
80 // should be cleaned up or done some other way, since this works for normal 79 // should be cleaned up or done some other way, since this works for normal
(...skipping 29 matching lines...) Expand all
110 // TabContents::Close() calls IsEventTracking(), and if it returns 109 // TabContents::Close() calls IsEventTracking(), and if it returns
111 // true CloseTabAfterEventTracking() is called and the close is not 110 // true CloseTabAfterEventTracking() is called and the close is not
112 // completed. 111 // completed.
113 virtual bool IsEventTracking() const = 0; 112 virtual bool IsEventTracking() const = 0;
114 virtual void CloseTabAfterEventTracking() = 0; 113 virtual void CloseTabAfterEventTracking() = 0;
115 114
116 // Get the bounds of the View, relative to the parent. 115 // Get the bounds of the View, relative to the parent.
117 // TODO(beng): Return a rect rather than using an out param. 116 // TODO(beng): Return a rect rather than using an out param.
118 virtual void GetViewBounds(gfx::Rect* out) const = 0; 117 virtual void GetViewBounds(gfx::Rect* out) const = 0;
119 118
119 // ---------------------------------------------------------------------------
120 // Functions for embedders.
121 // TODO(avi): Figure out where these go on the API surface.
122
123 // Installs a native view to cover the visible web contents. Removed by
124 // |RemoveOverlayView|. This is not a transfer of ownership, and the view must
125 // remain valid until removed.
126 virtual void InstallOverlayView(gfx::NativeView view) = 0;
127
128 // Removes the native overlay view installed by |InstallOverlayView|.
129 virtual void RemoveOverlayView() = 0;
130
120 protected: 131 protected:
121 TabContentsView(); // Abstract interface. 132 TabContentsView(); // Abstract interface.
122 133
123 private: 134 private:
124 DISALLOW_COPY_AND_ASSIGN(TabContentsView); 135 DISALLOW_COPY_AND_ASSIGN(TabContentsView);
125 }; 136 };
126 137
127 #endif // CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_ 138 #endif // CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_H_
OLDNEW
« no previous file with comments | « content/browser/tab_contents/tab_contents_observer.cc ('k') | content/browser/tab_contents/tab_contents_view_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698