Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 8477003: NaCl: Update revision in DEPS, r6965 -> r7108 (Closed)

Created:
9 years, 1 month ago by Roland McGrath
Modified:
9 years, 1 month ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, Brad Chen, bradn, bsy, Evgeniy Stepanov, khimg, krasin1, krasin, Karl, Mark Seaborn, noelallen_use_chromium, pdox, robertm
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r6965 -> r7108 This pulls in the following Native Client changes: r6966: (robertm) Cleanup dynloader loader test setup to use pnacl helpers and make it possible r6967: (pdox) Lower the f32 output precision for llvm_math_intrinsics from 6 digits to 5 digits after the decimal point. r6968: (pdox) Make native .so generation the default for PNaCl. r6969: (robertm) Document progress with building libstdc++ from gcc 4.6.1 using pnacl-clang r6970: (pdox) Disable initfini test for PNaCl GLibC. r6971: (krasin) gcc 4.6 fix: removed set but unused variables r6972: (pdox) Enable tests on the PNaCl glibc bot. r6973: (bsy) gcc 4.6 fixes r6974: (krasin) Fix build by disabling the assert. r6975: (krasin) Roll Chrome DEPS. r6976: (krasin) Revert Chrome DEPS rolling. pyauto has changed the API and the tests need to be updated. r6977: (robertm) PNaCl libstdc++: made one more files compile. Some script cleanup. r6978: (krasin) Add an ability to run_ncval_tests. This is a) convenient, b) needed to investigate the issue (see below). r6979: (robertm) PNaCl libstdc++ upgrade: this fixes compilation problems with atomics. r6980: (mcgrathr) Run buildbot_patch-toolchain-tries.sh for newlib toolchain builders too r6981: (robertm) Switch to using the gcc source in pnacl/git/gcc instead of downloading it from the web. r6982: (krasin) Fix ncval_tests: check for NCValidateFinish return value. r6983: (robertm) PNaCl libstdc++ update: This patch make libstdc++ compile but r6984: (pdox) Change the pnacl build script so that only the toolchain being built is clobbered. r6985: (robertm) With these additional changes we can create and install libstdc++ and use it with scons. r6986: (pdox) Update LLVM_PROJECT_REV and UPSTREAM_REV to bring LLVM up to r142467. r6987: (khim) Bump REVISIONS to bring the following changes: r6988: (khim) Force function alignment for TARGET_NACL r6989: (khim) Bump DEPS r6990: (mcgrathr) Enable binary file case in gio_test r6991: (sehr) Make validator require read sandboxing on ARM. Added some minor test extensions r6993: (sehr) Backout change 6991 (http://codereview.chromium.org/8275008/). Breaks r6994: (robertm) Update pnacl TC stable rev to pull in r6995: (mcgrathr) toolchain-git-try: Run newlib and/or glibc bots, depending what was changed r6996: (mcgrathr) Add GetUpdatedDEPS call to download_toolchains.py r6997: (pdox) Merge LLVM up to r142624. Pulls in upstreamed version of : r6998: (sehr) Re-enable read sandboxing for ARM. r6999: (pdox) Test intermixing pnacl-clang, pnacl-gcc, and nacl-gcc generated code in the callingconv test. r7000: (krasin) Prepare for Chrome DEPS: r7001: (krasin) Roll Chrome DEPS to r106670. r7002: (krasin) Revert Chrome DEPS to r105793. r7003: (eugenis) Disable some browser tests under Valgrind. r7004: (mcgrathr) libnacl_dyncode.so does not depend on libnacl.so r7005: (pdox) For PNaCl, move crt1, nacl_startup, libcrt_platform out of scons, and into the toolchain build. r7006: (pdox) Fix Spec2K tests for PNaCl by (temporarily) running libs-platform step manually. r7007: (krasin) Revert gyp-related changes back to r6999. I didn't (and don't) understand how GYP works and have made the problem even worse with these changes. r7008: (kschimpf) Start the process of building in validator testing code for pre/post conditions. r7009: (pdox) Roll PNaCl toolchain DEPS, and complete second part of CL: r7010: (pdox) Delete src/untrusted/startup, and remove libs-platform call from tests/spec2k/run_all. r7011: (krasin) Make build/common.gypi implicitly included. r7012: (krasin) Define nacl_standalone in the deprecated build/common.gypi, because src/ppapi/native_client/src/trusted/plugin/plugin.gyp in Chrome tree uses it. r7014: (pdox) Major cleanup to utman.sh r7015: (mcgrathr) Accept EACCES low-address mmap failure r7017: (mcgrathr) Add GioPio backend r7018: (pdox) pnacl utman.sh: Missing catch-all for FRONTEND parameter. r7019: (mcgrathr) Use GioPio for reading IRT in Chromium r7020: (robertm) Enable clang build of libstdc++ r7022: (krasin) Revert 7012 - Define nacl_standalone in the deprecated build/common.gypi, because src/ppapi/native_client/src/trusted/plugin/plugin.gyp in Chrome tree uses it. r7023: (krasin) Revert 7011 - Make build/common.gypi implicitly included. r7024: (robertm) Update llvm stable rev to include: r7025: (krasin) Do not build the plugin with GYP and thus remove the cyclic dependency. r7026: (pdox) Move tools/llvm/driver to pnacl/driver. http://codereview.chromium.org/8395028/ r7027: (pdox) Part 2 of 3: Moving tools/llvm to pnacl/. Review URL: http://codereview.chromium.org/8391032/ r7028: (pdox) Fix omitted move of merge-tool.sh. r7029: (mseaborn) x86-64 Windows: Ensure Breakpad works inside NaCl syscall handlers r7030: (robertm) Update stable rev to pull in: r7031: (krasin) Roll Chrome DEPS to r107314. r7032: (mcgrathr) Update nacl_uma test for Chrome nacl_helper UMA additions r7033: (mcgrathr) Reenable nacl_uma_test r7034: (pdox) Have the PNaCl bots continue testing even when there's a failure at some prior stage. r7035: (robertm) Make pyauto more resilent to bad output in one of the failure paths. r7037: (krasin) Roll Chrome DEPS to r107636 to see if any failures are gone. r7038: (krasin) Fix missing javascript file that is needed for FileSystem tests. r7039: (krasin) Disable broken crash and exit status tests. r7040: (krasin) Revert 7039 - Disable broken crash and exit status tests. r7041: (krasin) Disable a number of tests to make the tree green. r7042: (krasin) Follow up to r7041: disable two more tests. r7043: (krasin) 4 more tests to disable r7044: (pdox) Trigger rebuild (comment change) r7045: (robertm) Update the experimental libstdc++ 4.6 script and patch: r7046: (robertm) remove llvm-gcc calling convention test - as we are about to retire llvm-gcc. r7047: (noelallen) On Windows we incorrectly build crti_x86_32.S as 64 bit. r7048: (robertm) Roll deps to pull in latest pnacl TC r7049: (sehr) Don't dump core in NaClSrpcLog when array-typed parameters have a NULL pointer. r7050: (robertm) Stop builiding the llvm-gcc compiler, now that we have switched everything over r7051: (krasin) Suppress V8 GC bug. r7052: (krasin) Enable disabled tests to see the real picture. r7053: (krasin) Disable broken sel_universal tests again and put more detailed description. r7054: (krasin) Fix SConsctruct: missing quotes. r7055: (krasin) Revert 7051 - Suppress V8 GC bug. r7056: (robertm) PNaCl TC buidler: Remove several strip invocations from the pruning step for r7057: (bradchen) Whitespace change to provoke builders. r7058: (robertm) Enable translator tests for ARM on the bots. r7059: (krasin) Roll Chrome DEPS in preparation of testing against patched Chrome. r7060: (bradnelson) Pull in manually built chrome binaries for now (to shake out issues). r7061: (robertm) Cleanup and simplify build bot scripts for pnacl. r7062: (robertm) Cleanup some llvm-gcc related include paths. r7063: (bradchen) Whitespace change to start builders. r7065: (mcgrathr) Remove third_party/zlib from DEPS r7066: (mcgrathr) Remove unused Windows-only third_party DEPS r7067: (khim) Fix recursive pthread_once. r7068: (khim) Use compressed patches. Use curl if wget is not available. r7069: (robertm) Update PNaCl live TC. r7070: (mcgrathr) Point mingw/bin DEPS reference at its new home r7072: (mcgrathr) Roll toolchain DEPS r7073: (mcgrathr) Point NSIS DEPS reference at its new home r7075: (bsy) cleanup. remove a publish rule that referred to a non-existent file. r7076: (mcgrathr) Remove third_party/mesa from DEPS r7077: (pdox) Merge with LLVM up to r143276. r7078: (mcgrathr) Collapse gpu/ subdirectory DEPS into one r7079: (mcgrathr) Collapse third_party/ subdirectory DEPS into one r7080: (sehr) Make sandboxed translator use new parameter profile (to get metadata for r7081: (pdox) Make handling of -T more precise. r7083: (krasin) Revert using patched Chrome binary for Linux x86-64. Chrome LKGR with the fix is about to be ready. r7084: (mcgrathr) Update tools_rev to 7082 r7085: (noelallen) Remove disable_untrusted r7086: (bsy) always print mem_start. r7087: (pdox) Fix GlibC PNaCl build. r7089: (eugenis) Pull new Valgrind binaries. r7090: (khim) Bump REVISIONS. r7091: (robertm) Removing perf tools from build script. r7092: (khim) Bump DEPS r7093: (pdox) Add preliminary script to build libgcc_eh from gcc-4.6 git repo. r7094: (robertm) This pulls in: r7095: (mcgrathr) Update newlib revision to 590577e r7096: (pdox) Remove PIC and ad-hoc shared library tests for X86-32 and X86-64. r7097: (pdox) * Roll UPSTREAM_REV to bring in CL: http://codereview.chromium.org/8439026 r7098: (robertm) Eliminate AS_ refererenes in pnacl/build.sh r7099: (robertm) Update DEPS to pull in most recent pnacl TC. r7100: (mcgrathr) Update toolchain DEPS r7101: (sehr) Reenable pnacl_client_translator tests. r7102: (robertm) Simplify code around binutils-sb, e.g. always assume srpc. r7103: (mcgrathr) Update Chrome DEPS to 108505 r7104: (bsy) invoke sorted(...iteritems()) so python2.7 won't choke on .sort() on iterator. r7105: (noelallen) Fix DEPS for 64 bit crt_platform on Windows r7106: (pdox) Roll UPSTREAM_REV to bring in: r7107: (pdox) Switch to using libgcc_eh.a built from gcc-4.6. r7108: (robertm) Update live PNaCl TC to latest version BUG=none TEST=nacl_integration Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M DEPS View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Roland McGrath
PTAL. Trybots passed nacl_integration test.
9 years, 1 month ago (2011-11-04 19:51:38 UTC) #1
Mark Seaborn
LGTM as long as nacl_integration is still enabled in Chromium.
9 years, 1 month ago (2011-11-04 19:55:27 UTC) #2
Roland McGrath
On 2011/11/04 19:55:27, Mark Seaborn wrote: > LGTM as long as nacl_integration is still enabled ...
9 years, 1 month ago (2011-11-04 20:09:50 UTC) #3
sehr (please use chromium)
9 years, 1 month ago (2011-11-04 20:50:00 UTC) #4
On 2011/11/04 20:09:50, Roland McGrath wrote:
> On 2011/11/04 19:55:27, Mark Seaborn wrote:
> > LGTM as long as nacl_integration is still enabled in Chromium.
> 
> It is still as it has been today, i.e. disabled only on Mac.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698