Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1154)

Issue 8439026: Get rid of libgcc and nacl_read_tp symbol preservation hacks. (Closed)

Created:
9 years, 1 month ago by pdox
Modified:
9 years, 1 month ago
CC:
pnacl-team_google.com
Base URL:
http://code.google.com/p/nacl-llvm-branches.upstream
Visibility:
Public.

Description

This is no longer needed for libgcc since it is compiled to native code. nacl_read_tp can be preserved correctly with a one-line fix to crt1.x. This reverses the actions of issue 1520. BUG= http://code.google.com/p/nativeclient/issues/detail?id=1520

Patch Set 1 #

Patch Set 2 : missing localmod marker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -123 lines) Patch
M llvm/lib/CodeGen/IntrinsicLowering.cpp View 1 7 chunks +3 lines, -123 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pdox
9 years, 1 month ago (2011-11-02 01:11:38 UTC) #1
jvoung - send to chromium...
Do you have a link to the paired nacl_startup change?
9 years, 1 month ago (2011-11-02 01:21:00 UTC) #2
robertm
+1 please file a bug so we can track these changes together. Also added krasin ...
9 years, 1 month ago (2011-11-02 13:55:04 UTC) #3
pdox
robert, This is not a bug. I'm cleaning out dead code.
9 years, 1 month ago (2011-11-02 16:04:17 UTC) #4
robertm
can you check the URL for the corresponding CL On 2011/11/02 16:04:17, pdox wrote: > ...
9 years, 1 month ago (2011-11-02 16:38:13 UTC) #5
pdox
Fixed CL link. Robert, that doc says all "significant" CLs need a bug. This is ...
9 years, 1 month ago (2011-11-02 16:47:04 UTC) #6
pdox
PTAL
9 years, 1 month ago (2011-11-02 17:00:09 UTC) #7
robertm
On 2011/11/02 17:00:09, pdox wrote: > PTAL Here is a bug that should be referenced ...
9 years, 1 month ago (2011-11-02 17:27:08 UTC) #8
pdox
added bug
9 years, 1 month ago (2011-11-02 18:27:51 UTC) #9
robertm
9 years, 1 month ago (2011-11-02 18:31:46 UTC) #10
LGTM

On 2011/11/02 18:27:51, pdox wrote:
> added bug

Powered by Google App Engine
This is Rietveld 408576698