ui/gfx/canvas_skia_win.cc - Issue 8476019: ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/canvas_skia_win.cc

Issue 8476019: ui/gfx: Convert Canvas::DrawRectInt() to use gfx::Rect. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/canvas_skia_win.cc

diff --git a/ui/gfx/canvas_skia_win.cc b/ui/gfx/canvas_skia_win.cc

index 1c4536816d895381af3ded7e7c1f64fb916dde0d..949a0565df068badd2f55c6a3d394c25efd67e2c 100644

--- a/ui/gfx/canvas_skia_win.cc

+++ b/ui/gfx/canvas_skia_win.cc

@@ -418,7 +418,7 @@ void CanvasSkia::DrawStringWithHalo(const string16& text,

CanvasSkia text_canvas(w + 2, h + 2, true);

Peter Kasting 2011/11/05 01:10:10 Nit: We could probably create a rect with this siz

tfarina 2011/11/05 02:23:24 Done.

SkPaint bkgnd_paint;

bkgnd_paint.setColor(halo_color);

- text_canvas.DrawRectInt(0, 0, w + 2, h + 2, bkgnd_paint);

+ text_canvas.DrawRect(gfx::Rect(0, 0, w + 2, h + 2), bkgnd_paint);

// Draw the text into the temporary buffer. This will have correct

// ClearType since the background color is the same as the halo color.