Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 8473011: Revert 110811 - Fix testAboutAppCacheTab by replacing External 500 error URL to working URL. (Closed)

Created:
9 years, 1 month ago by Nirnimesh
Modified:
9 years, 1 month ago
Reviewers:
dyu1
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Revert 110811 - Fix testAboutAppCacheTab by replacing External 500 error URL to working URL. I'm reverting because this test is consistently failing on all bots. Remember that it's the committer's responsibility to ensure that his change lands safely. ====================================================================== FAIL: special_tabs.SpecialTabsTest.testAboutAppCacheTab: "Test App Cache tab to confirm about page populates caches." ---------------------------------------------------------------------- Traceback (most recent call last): File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/special_tabs.py", line 317, in testAboutAppCacheTab self._VerifyAppCacheInternals() File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/special_tabs.py", line 207, in _VerifyAppCacheInternals []) File "/mnt/data/b/build/slave/Linux__deb_/build/src/chrome/test/functional/test_utils.py", line 232, in StringContentCheck msg='"%s" missing from content.' % s) AssertionError: "Manifest" missing from content. BUG=102517 TEST=none Review URL: http://codereview.chromium.org/8533018 TBR=dyu@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/functional/special_tabs.py View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nirnimesh
9 years, 1 month ago (2011-11-20 03:52:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698