Fix testAboutAppCacheTab by replacing External 500 error URL to working URL.

Fix testAboutAppCacheTab by replacing External 500 error URL to working URL.

BUG=102517
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110811

[Nirnimesh, 2011-11-14 19:37:30]

I'm not so sure about replacing with an even more non-standard webpage. Can't
this test be rewritten to use the local http server?

[dyu1, 2011-11-14 20:15:44]

On 2011/11/14 19:37:30, Nirnimesh wrote:
> I'm not so sure about replacing with an even more non-standard webpage. Can't
> this test be rewritten to use the local http server?

I would need to add the following to the .htaccess file "AddType
text/cache-manifest .manifest" can I do so on the local http server? Let me know
how to do it.

[Nirnimesh, 2011-11-15 20:01:56]

On 2011/11/14 20:15:44, dyu1 wrote:
> On 2011/11/14 19:37:30, Nirnimesh wrote:
> > I'm not so sure about replacing with an even more non-standard webpage.
Can't
> > this test be rewritten to use the local http server?
> 
> I would need to add the following to the .htaccess file "AddType
> text/cache-manifest .manifest" can I do so on the local http server? Let me
know
> how to do it.

At least use a URL that's more reliable. Relying on random webpages from random
people doesn't really "fix" the problem here.

How about: http://www.webkit.org/demos/sticky-notes/index.html

[dyu1, 2011-11-17 20:16:59]

Done

On 2011/11/15 20:01:56, Nirnimesh wrote:
> On 2011/11/14 20:15:44, dyu1 wrote:
> > On 2011/11/14 19:37:30, Nirnimesh wrote:
> > > I'm not so sure about replacing with an even more non-standard webpage.
> Can't
> > > this test be rewritten to use the local http server?
> > 
> > I would need to add the following to the .htaccess file "AddType
> > text/cache-manifest .manifest" can I do so on the local http server? Let me
> know
> > how to do it.
> 
> At least use a URL that's more reliable. Relying on random webpages from
random
> people doesn't really "fix" the problem here.
> 
> How about: http://www.webkit.org/demos/sticky-notes/index.html

[Nirnimesh, 2011-11-17 20:21:57]

Enable the test please

[dyu1, 2011-11-17 20:27:35]

On 2011/11/17 20:21:57, Nirnimesh wrote:
> Enable the test please

Done, although it looks like PYAUTO_TESTS has additional changes from my other
pending CL.

[Nirnimesh, 2011-11-18 02:04:33]

On 2011/11/17 20:27:35, dyu1 wrote:
> On 2011/11/17 20:21:57, Nirnimesh wrote:
> > Enable the test please
> 
> Done, although it looks like PYAUTO_TESTS has additional changes from my other
> pending CL.

Please get rid of the unrelated changes. You don't want this commit to poison
the PYAUTO_TESTS file.

[dyu1, 2011-11-18 20:26:35]

Done

On 2011/11/18 02:04:33, Nirnimesh wrote:
> On 2011/11/17 20:27:35, dyu1 wrote:
> > On 2011/11/17 20:21:57, Nirnimesh wrote:
> > > Enable the test please
> > 
> > Done, although it looks like PYAUTO_TESTS has additional changes from my
other
> > pending CL.
> 
> Please get rid of the unrelated changes. You don't want this commit to poison
> the PYAUTO_TESTS file.

[Nirnimesh, 2011-11-18 20:38:13]

http://codereview.chromium.org/8533018/diff/16001/chrome/test/functional/PYAU...
File chrome/test/functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/8533018/diff/16001/chrome/test/functional/PYAU...
chrome/test/functional/PYAUTO_TESTS:97: # Cause browser crash.  crbug.com/103427
Why is this in here?

[dyu1, 2011-11-18 20:39:31]

This showed up in the latest revision. Someone added it between yesterday and
today. Did you want me to remove it?

On 2011/11/18 20:38:13, Nirnimesh wrote:
>
http://codereview.chromium.org/8533018/diff/16001/chrome/test/functional/PYAU...
> File chrome/test/functional/PYAUTO_TESTS (right):
> 
>
http://codereview.chromium.org/8533018/diff/16001/chrome/test/functional/PYAU...
> chrome/test/functional/PYAUTO_TESTS:97: # Cause browser crash. 
crbug.com/103427
> Why is this in here?

[Nirnimesh, 2011-11-18 22:06:39]

On 2011/11/18 20:39:31, dyu1 wrote:
> This showed up in the latest revision. Someone added it between yesterday and
> today. Did you want me to remove it?

Yes, of course. Your commit will fail without it.

Everytime after uploading a patch and before sending it out for codereview,
please ensure that you don't have leftover cruft from other CLs. If there are
leftover cruft from other CLs, remove them. If there is leftover stuff from
other tot, rebase your checkout.

[dyu1, 2011-11-18 22:46:42]

http://codereview.chromium.org/8533018/diff/16001/chrome/test/functional/PYAU...
File chrome/test/functional/PYAUTO_TESTS (right):

http://codereview.chromium.org/8533018/diff/16001/chrome/test/functional/PYAU...
chrome/test/functional/PYAUTO_TESTS:97: # Cause browser crash.  crbug.com/103427
On 2011/11/18 20:38:14, Nirnimesh wrote:
> Why is this in here?

Removed

[Nirnimesh, 2011-11-18 22:49:34]

http://codereview.chromium.org/8533018/diff/22002/chrome/test/functional/PYAU...
File chrome/test/functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/8533018/diff/22002/chrome/test/functional/PYAU...
chrome/test/functional/PYAUTO_TESTS:97: # Cause browser crash.  crbug.com/103427
Now it looks like you're deleting this line.

http://codereview.chromium.org/8533018/diff/22002/chrome/test/functional/PYAU...
chrome/test/functional/PYAUTO_TESTS:116: # crbug.com/102517 -- external webpage
throws 500
The only changes in this file should be these two lines. Nothing else

[dyu1, 2011-11-18 23:16:30]

http://codereview.chromium.org/8533018/diff/22002/chrome/test/functional/PYAU...
File chrome/test/functional/PYAUTO_TESTS (left):

http://codereview.chromium.org/8533018/diff/22002/chrome/test/functional/PYAU...
chrome/test/functional/PYAUTO_TESTS:97: # Cause browser crash.  crbug.com/103427
On 2011/11/18 22:49:35, Nirnimesh wrote:
> Now it looks like you're deleting this line.

I did delete it since this was merged in after my last submit. The change came
from someone else. I will add this back.

http://codereview.chromium.org/8533018/diff/22002/chrome/test/functional/PYAU...
chrome/test/functional/PYAUTO_TESTS:116: # crbug.com/102517 -- external webpage
throws 500
On 2011/11/18 22:49:35, Nirnimesh wrote:
> The only changes in this file should be these two lines. Nothing else

It was difficult to make the adjustments since I have another CL with
PYAUTO_TEST pending approval. I'm using SVN and it doesn't handle multiple
changes to the same file across pending CLs very well.

[Nirnimesh, 2011-11-19 01:44:17]

People using svn/gcl use different workspaces for different CLs. That's why git
rocks :)

LGTM