Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 8473006: Revert 110824 - Variety of crashes on XP dbg bots (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi
Modified:
9 years, 1 month ago
Reviewers:
msw
CC:
chromium-reviews, msw+watch_chromium.org, Aaron Boodman, Erik does not do reviews, alicet1, mihaip+watch_chromium.org
Visibility:
Public.

Description

Revert 110824 - Variety of crashes on XP dbg bots Rebase ExtensionInstalledBubble on the new views bubble. Move some arrow anchor/location logic; etc. Expose non-const |chevron|, and |location_entry_view|. Add a setter for BubbleDelegateView's |anchor_view|. BUG=98323 TEST=ExtensionInstalledBubbles function as before. Review URL: http://codereview.chromium.org/8590047 TBR=msw@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -45 lines) Patch
M chrome/browser/ui/views/browser_actions_container.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.h View 4 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 7 chunks +43 lines, -30 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
9 years, 1 month ago (2011-11-19 04:20:47 UTC) #1
Ryan Sleevi
9 years, 1 month ago (2011-11-19 04:22:44 UTC) #2
http://build.chromium.org/p/chromium/builders/XP%20Tests%20%28dbg%29%286%29/b...

http://build.chromium.org/p/chromium/builders/XP%20Tests%20%28dbg%29%285%29/b...

http://build.chromium.org/p/chromium/builders/XP%20Tests%20%28dbg%29%283%29/b...

Note: Google Test filter = ExtensionManagementTest.InstallRequiresConfirm
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from ExtensionManagementTest, where TypeParam = 
[ RUN      ] ExtensionManagementTest.InstallRequiresConfirm
[3000:3008:1118/195506:1135656:ERROR:external_registry_extension_loader_win.cc(84)]
Missing value path for key
Software\Google\Chrome\Extensions\jfmjfhklogoienhpfnppmbcbjfjnkonk.
Backtrace:
	(No symbol) [0x36363636]
	DelayedLowerToken [0x013E8DD6+13479158]
	DelayedLowerToken [0x01406950+13600880]
	DelayedLowerToken [0x01402EC6+13585894]
	(No symbol) [0x036F3995]
	(No symbol) [0x036F4A3B]
	GetDC [0x7E418734+109]
	UserLpkPSMTextOut [0x7E42BDF1+460]
	DefWindowProcW [0x7E428EA0+384]
	IsWindowInDestroy [0x7E42B16F+73]
	KiUserCallbackDispatcher [0x7C90E473+19]
	DelayedLowerToken [0x01D0B51C+23057468]
	DelayedLowerToken [0x00A96E4F+3706223]
	DelayedLowerToken [0x019C3016+19615542]
	DelayedLowerToken [0x019C31C3+19615971]
	DelayedLowerToken [0x019C3B70+19618448]
	DelayedLowerToken [0x01A20CE4+19999748]
	DelayedLowerToken [0x01A20732+19998290]
	DelayedLowerToken [0x019C2C4B+19614571]
	DelayedLowerToken [0x019C2A4E+19614062]
	DelayedLowerToken [0x019C3FA9+19619529]
	DelayedLowerToken [0x01A36007+20086567]
	DelayedLowerToken [0x01A35A4E+20085102]
	DelayedLowerToken [0x01A359B1+20084945]
	DelayedLowerToken [0x02293C1E+28859198]
	DelayedLowerToken [0x0247340C+30823212]
	DelayedLowerToken [0x02445721+30635585]
	(No symbol) [0x0254F707]
	(No symbol) [0x0254F969]
	DelayedLowerToken [0x00B58B40+4500064]
	DelayedLowerToken [0x00A65170+3502224]
	(No symbol) [0x02689932]
	DelayedLowerToken [0x01A351A7+20082887]
	DelayedLowerToken [0x01619A77+15776151]
	DelayedLowerToken [0x0160EB0B+15731243]
	DelayedLowerToken [0x0160F31D+15733309]
	DelayedLowerToken [0x0160F9FF+15735071]
	DelayedLowerToken [0x01614270+15753616]
	DelayedLowerToken [0x01619CE7+15776775]
	DelayedLowerToken [0x0161323C+15749468]
	DelayedLowerToken [0x0198C3E9+19391241]
	(No symbol) [0x004DDDDB]
	(No symbol) [0x0041A0B1]
	(No symbol) [0x004DDBC0]
	(No symbol) [0x006E3A1F]
	RegisterWaitForInputIdle [0x7C817077+73]
[1118/195551:ERROR:test_launcher.cc(375)] Test timeout (45000 ms) exceeded for
ExtensionManagementTest.InstallRequiresConfirm

Note: Google Test filter = WebstoreInlineInstallTest.Install
[==========] Running 1 test from 1 test case.
[----------] Global test environment set-up.
[----------] 1 test from WebstoreInlineInstallTest, where TypeParam = 
[ RUN      ] WebstoreInlineInstallTest.Install
[3936:3868:1118/195456:1039250:WARNING:extension.cc(291)] Override URL passed
for Chrome Web Store should not contain a port.  Removing it.
[3936:3868:1118/195459:1041656:INFO:CONSOLE(8)] "Page loaded", source:
http://app.com:1240/files/extensions/api_test/webstore_inline_install/install...
(8)
[3936:3868:1118/195459:1041687:INFO:CONSOLE(11)] "In runTest", source:
http://app.com:1240/files/extensions/api_test/webstore_inline_install/install...
(11)
[3936:3868:1118/195500:1042812:INFO:CONSOLE(22)] "Ran test, sending response",
source:
http://app.com:1240/files/extensions/api_test/webstore_inline_install/install...
(22)
[3936:3868:1118/195500:1042828:INFO:CONSOLE(24)] "Test complete", source:
http://app.com:1240/files/extensions/api_test/webstore_inline_install/install...
(24)
Backtrace:
	(No symbol) [0x36363636]
	DelayedLowerToken [0x013E8DD6+13479158]
	DelayedLowerToken [0x01406950+13600880]
	DelayedLowerToken [0x01402EC6+13585894]
	(No symbol) [0x036F3995]
	(No symbol) [0x036F4A3B]
	GetDC [0x7E418734+109]
	UserLpkPSMTextOut [0x7E42BDF1+460]
	DefWindowProcW [0x7E428EA0+384]
	IsWindowInDestroy [0x7E42B16F+73]
	KiUserCallbackDispatcher [0x7C90E473+19]
	DelayedLowerToken [0x01D0B51C+23057468]
	DelayedLowerToken [0x00A96E4F+3706223]
	DelayedLowerToken [0x019C3016+19615542]
	DelayedLowerToken [0x019C31C3+19615971]
	DelayedLowerToken [0x019C3B70+19618448]
	DelayedLowerToken [0x01A20CE4+19999748]
	DelayedLowerToken [0x01A20732+19998290]
	DelayedLowerToken [0x019C2C4B+19614571]
	DelayedLowerToken [0x019C2A4E+19614062]
	DelayedLowerToken [0x019C3FA9+19619529]
	DelayedLowerToken [0x01A36007+20086567]
	DelayedLowerToken [0x01A35A4E+20085102]
	DelayedLowerToken [0x01A359B1+20084945]
	DelayedLowerToken [0x02293C1E+28859198]
	DelayedLowerToken [0x0247340C+30823212]
	DelayedLowerToken [0x02445721+30635585]
	(No symbol) [0x0254F707]
	(No symbol) [0x0254F969]
	DelayedLowerToken [0x00B58B40+4500064]
	DelayedLowerToken [0x00A65170+3502224]
	(No symbol) [0x02689932]
	DelayedLowerToken [0x01A351A7+20082887]
	DelayedLowerToken [0x01619A77+15776151]
	DelayedLowerToken [0x0160EB0B+15731243]
	DelayedLowerToken [0x0160F31D+15733309]
	DelayedLowerToken [0x0160F9FF+15735071]
	DelayedLowerToken [0x01614270+15753616]
	DelayedLowerToken [0x01619CE7+15776775]
	DelayedLowerToken [0x0161323C+15749468]
	DelayedLowerToken [0x0198C3E9+19391241]
	(No symbol) [0x004DDDDB]
	(No symbol) [0x0041A0B1]
	(No symbol) [0x004DDBC0]
	(No symbol) [0x006E3A1F]
	RegisterWaitForInputIdle [0x7C817077+73]

Powered by Google App Engine
This is Rietveld 408576698