Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8590047: Rebase ExtensionInstalledBubble on the new views bubble. (Closed)

Created:
9 years, 1 month ago by msw
Modified:
9 years, 1 month ago
CC:
chromium-reviews, msw+watch_chromium.org, tfarina, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, alicet1, dhollowa
Visibility:
Public.

Description

Rebase ExtensionInstalledBubble on the new views bubble. Move some arrow anchor/location logic; etc. Expose non-const |chevron|, and |location_entry_view|. Add a setter for BubbleDelegateView's |anchor_view|. BUG=98323 TEST=ExtensionInstalledBubbles function as before. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110824 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110858

Patch Set 1 : Rebase ExtensionInstalledBubble on the new views bubble. #

Total comments: 2

Patch Set 2 : Remove unnecesary forward decls. #

Patch Set 3 : Sync and merge. #

Patch Set 4 : Sync and merge again... #

Patch Set 5 : Sync and merge again... #

Patch Set 6 : Remove the RefCountedThreadSafe lifetime management. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -67 lines) Patch
M chrome/browser/ui/views/browser_actions_container.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.h View 1 2 3 4 5 4 chunks +12 lines, -18 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_installed_bubble.cc View 1 2 3 4 5 9 chunks +34 lines, -49 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/bubble/bubble_delegate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
msw
Alice: PTAL; thanks!
9 years, 1 month ago (2011-11-17 23:38:34 UTC) #1
alicet1
lgtm http://codereview.chromium.org/8590047/diff/2001/chrome/browser/ui/views/extensions/extension_installed_bubble.h File chrome/browser/ui/views/extensions/extension_installed_bubble.h (right): http://codereview.chromium.org/8590047/diff/2001/chrome/browser/ui/views/extensions/extension_installed_bubble.h#newcode18 chrome/browser/ui/views/extensions/extension_installed_bubble.h:18: class SkBitmap; can remove this or the include ...
9 years, 1 month ago (2011-11-18 01:00:54 UTC) #2
msw
Ben PTAL/stamp; thanks! http://codereview.chromium.org/8590047/diff/2001/chrome/browser/ui/views/extensions/extension_installed_bubble.h File chrome/browser/ui/views/extensions/extension_installed_bubble.h (right): http://codereview.chromium.org/8590047/diff/2001/chrome/browser/ui/views/extensions/extension_installed_bubble.h#newcode18 chrome/browser/ui/views/extensions/extension_installed_bubble.h:18: class SkBitmap; On 2011/11/18 01:00:54, alicet1 ...
9 years, 1 month ago (2011-11-18 01:15:28 UTC) #3
msw
Ben PTAL/stamp; thanks! (Re-sending after fixing reviewers list.)
9 years, 1 month ago (2011-11-18 01:17:33 UTC) #4
Ben Goodger (Google)
lgtm
9 years, 1 month ago (2011-11-18 16:42:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8590047/7001
9 years, 1 month ago (2011-11-18 18:03:47 UTC) #6
commit-bot: I haz the power
Try job failure for 8590047-7001 (retry) on linux_rel for step "ui_tests". It's a second try, ...
9 years, 1 month ago (2011-11-18 19:17:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8590047/7001
9 years, 1 month ago (2011-11-18 20:46:16 UTC) #8
commit-bot: I haz the power
Can't apply patch for file views/bubble/bubble_delegate.h. While running patch -p1 --forward --force; patching file views/bubble/bubble_delegate.h ...
9 years, 1 month ago (2011-11-18 22:17:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8590047/10001
9 years, 1 month ago (2011-11-18 22:51:16 UTC) #10
commit-bot: I haz the power
Can't apply patch for file chrome/browser/ui/views/extensions/extension_installed_bubble.cc. While running patch -p1 --forward --force; patching file chrome/browser/ui/views/extensions/extension_installed_bubble.cc ...
9 years, 1 month ago (2011-11-19 00:09:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8590047/4003
9 years, 1 month ago (2011-11-19 00:21:52 UTC) #12
commit-bot: I haz the power
Try job failure for 8590047-4003 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-19 00:50:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8590047/4003
9 years, 1 month ago (2011-11-19 01:05:38 UTC) #14
commit-bot: I haz the power
Try job failure for 8590047-4003 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-19 02:06:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8590047/16003
9 years, 1 month ago (2011-11-19 02:10:49 UTC) #16
commit-bot: I haz the power
9 years, 1 month ago (2011-11-19 03:15:17 UTC) #17 
Change committed as 110824

Powered by Google App Engine
This is Rietveld 408576698