Issue 847005: Bug fixes and timing code. This is the first fully functional code,

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 847005: Bug fixes and timing code. This is the first fully functional code, (Closed)

Created:
10 years, 9 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
gauravsh

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Description

Bug fixes and timing code. This is the first fully functional code, which I used to report timing results.

Patch Set 1 #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -7 lines)			Patch
M	src/platform/tpm_lite/src/testsuite/readonly.c	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	src/platform/tpm_lite/src/tlcl/generator.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/platform/tpm_lite/src/tlcl/tlcl.c	View	3 chunks	+7 lines, -0 lines	1 comment	Download
M	src/platform/tpm_lite/src/tlcl/tlcl_internal.h	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

Just a small set of changes. I'd like to have this in because it fixes ...

10 years, 9 months ago (2010-03-13 00:40:00 UTC) #1

gauravsh

LGTM http://codereview.chromium.org/847005/diff/1/4 File src/platform/tpm_lite/src/tlcl/tlcl.c (right): http://codereview.chromium.org/847005/diff/1/4#newcode139 src/platform/tpm_lite/src/tlcl/tlcl.c:139: gettimeofday(&before, NULL); For better precision I would recommend ...

10 years, 9 months ago (2010-03-13 00:47:47 UTC) #2

Luigi Semenzato

10 years, 9 months ago (2010-03-13 01:24:10 UTC) #3

Thank you for the suggestion.  I will commit as is, but will change it in a
future revision.


On Fri, Mar 12, 2010 at 4:47 PM, <gauravsh@chromium.org> wrote:

> LGTM
>
>
> http://codereview.chromium.org/847005/diff/1/4
> File src/platform/tpm_lite/src/tlcl/tlcl.c (right):
>
> http://codereview.chromium.org/847005/diff/1/4#newcode139
> src/platform/tpm_lite/src/tlcl/tlcl.c:139: gettimeofday(&before, NULL);
> For better precision I would recommend using clock_gettime() and link
> with the -lrt library. There is some timer code in
> src/platform/vboot_reference/tests/timer_utility.[ch] which you can
> directly use.
>
>
> http://codereview.chromium.org/847005
>

Expand Messages | Collapse Messages