Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8470005: Add OVERRIDE to chrome/browser/sync/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
CC:
chromium-reviews, ncarter (slow), Raghu Simha, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

Add OVERRIDE to chrome/browser/sync/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110976

Patch Set 1 #

Patch Set 2 : includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+258 lines, -198 lines) Patch
M chrome/browser/sync/abstract_profile_sync_service_test.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/all_status.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/apply_updates_command.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/build_and_process_conflict_sets_command.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/build_commit_command.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/cleanup_disabled_types_command.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/clear_data_command.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/engine/download_updates_command.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/get_commit_ids_command.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/mock_model_safe_workers.h View 1 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/engine/model_changing_syncer_command.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/post_commit_message_command.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/process_commit_response_command.h View 1 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/sync/engine/process_updates_command.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/resolve_conflicts_command.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/store_timestamps_command.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer_end_command.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/engine/verify_updates_command.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/app_data_type_controller.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_data_type_controller.h View 1 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_model_associator.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/data_type_manager_impl.h View 1 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/extension_data_type_controller.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/frontend_data_type_controller.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/history_model_worker.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/http_bridge.h View 3 chunks +15 lines, -13 lines 0 comments Download
M chrome/browser/sync/glue/new_non_frontend_data_type_controller_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/non_frontend_data_type_controller.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/password_data_type_controller.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 2 chunks +11 lines, -10 lines 0 comments Download
M chrome/browser/sync/glue/session_data_type_controller.h View 1 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/theme_data_type_controller.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_data_type_controller.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/sync/glue/ui_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/debug_info_event_listener.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/internal_api/read_node.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/internal_api/read_transaction.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/internal_api/syncapi_server_connection_manager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/internal_api/write_node.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/sync/internal_api/write_transaction.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/notifier/chrome_invalidation_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/notifier/p2p_notifier.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_factory_impl.h View 1 2 chunks +20 lines, -18 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/signin_manager.h View 1 3 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/sync/signin_manager_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/engine/test_directory_setter_upper.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/bookmarks_helper.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/migration_errors_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/util/extensions_activity_monitor.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/util/sqlite_utils.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
Just adding OVERRIDEs.
9 years, 1 month ago (2011-11-19 02:02:57 UTC) #1
Avi (use Gerrit)
Looking for an owner rubberstamp. Change is just adding OVERRIDEs, nothing more.
9 years, 1 month ago (2011-11-21 17:37:30 UTC) #2
akalin
On 2011/11/21 17:37:30, Avi wrote: > Looking for an owner rubberstamp. Change is just adding ...
9 years, 1 month ago (2011-11-21 17:38:41 UTC) #3
Avi (use Gerrit)
ptal
9 years, 1 month ago (2011-11-21 18:19:35 UTC) #4
akalin
9 years, 1 month ago (2011-11-21 18:25:39 UTC) #5 
LGTM

Powered by Google App Engine
This is Rietveld 408576698