Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: chrome/browser/sync/engine/process_updates_command.h

Issue 8470005: Add OVERRIDE to chrome/browser/sync/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: includes Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/compiler_specific.h"
9 #include "chrome/browser/sync/engine/model_changing_syncer_command.h" 10 #include "chrome/browser/sync/engine/model_changing_syncer_command.h"
10 #include "chrome/browser/sync/engine/syncer_types.h" 11 #include "chrome/browser/sync/engine/syncer_types.h"
11 12
12 namespace syncable { 13 namespace syncable {
13 class ScopedDirLookup; 14 class ScopedDirLookup;
14 class WriteTransaction; 15 class WriteTransaction;
15 } 16 }
16 17
17 namespace sync_pb { 18 namespace sync_pb {
18 class SyncEntity; 19 class SyncEntity;
19 } 20 }
20 21
21 namespace browser_sync { 22 namespace browser_sync {
22 23
23 // A syncer command for processing updates. 24 // A syncer command for processing updates.
24 // 25 //
25 // Preconditions - updates in the SyncerSesssion have been downloaded 26 // Preconditions - updates in the SyncerSesssion have been downloaded
26 // and verified. 27 // and verified.
27 // 28 //
28 // Postconditions - All of the verified SyncEntity data will be copied to 29 // Postconditions - All of the verified SyncEntity data will be copied to
29 // the server fields of the corresponding syncable entries. 30 // the server fields of the corresponding syncable entries.
30 // TODO(tim): This should not be ModelChanging (bug 36592). 31 // TODO(tim): This should not be ModelChanging (bug 36592).
31 class ProcessUpdatesCommand : public ModelChangingSyncerCommand { 32 class ProcessUpdatesCommand : public ModelChangingSyncerCommand {
32 public: 33 public:
33 ProcessUpdatesCommand(); 34 ProcessUpdatesCommand();
34 virtual ~ProcessUpdatesCommand(); 35 virtual ~ProcessUpdatesCommand();
35 36
36 // ModelChangingSyncerCommand implementation. 37 // ModelChangingSyncerCommand implementation.
37 virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session); 38 virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session) OVERRIDE;
38 virtual void ModelChangingExecuteImpl(sessions::SyncSession* session); 39 virtual void ModelChangingExecuteImpl(
40 sessions::SyncSession* session) OVERRIDE;
39 41
40 private: 42 private:
41 ServerUpdateProcessingResult ProcessUpdate( 43 ServerUpdateProcessingResult ProcessUpdate(
42 const syncable::ScopedDirLookup& dir, 44 const syncable::ScopedDirLookup& dir,
43 const sync_pb::SyncEntity& proto_update, 45 const sync_pb::SyncEntity& proto_update,
44 syncable::WriteTransaction* const trans); 46 syncable::WriteTransaction* const trans);
45 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand); 47 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand);
46 }; 48 };
47 49
48 } // namespace browser_sync 50 } // namespace browser_sync
49 51
50 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 52 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/process_commit_response_command.h ('k') | chrome/browser/sync/engine/resolve_conflicts_command.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698