Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: frog/gen.dart

Issue 8469016: Adding in-browser correctness testing via selenium. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: '' Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frog/frogsh ('k') | tests/language/language.status » ('j') | tools/test.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/gen.dart
===================================================================
--- frog/gen.dart (revision 1427)
+++ frog/gen.dart (working copy)
@@ -324,8 +324,15 @@
writer.enterBlock('Object.defineProperty(' +
'${property.declaringType.jsname}.prototype, "${property.jsname}", {');
if (property.getter != null) {
- writer.writeln(
- 'get: ${property.declaringType.jsname}.prototype.${property.getter.jsname},');
+ writer.write(
+ 'get: ${property.declaringType.jsname}.prototype.${property.getter.jsname}');
+ String endOfLine = '';
+ // The shenanigan below is to make IE happy -- IE 9 doesn't like a
+ // trailing comma on the last element in a list.
+ if (property.setter != null) {
+ endOfLine = ',';
+ }
+ writer.writeln(endOfLine);
Siggi Cherem (dart-lang) 2011/11/10 23:04:37 (nit): for this short logic, I prefer doing this i
}
if (property.setter != null) {
writer.writeln(
« no previous file with comments | « frog/frogsh ('k') | tests/language/language.status » ('j') | tools/test.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698