Adding in-browser correctness testing via selenium.

frog/gen.dart

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Top level generator object for writing code and keeping track of
  * dependencies.
  *
  * Should have two compilation models, but only one implemented so far.
  *
@@ skipping 306 matching lines @@
   }
 
   _writeProperty(PropertyMember property) {
     if (property.getter != null) _writeMethod(property.getter);
     if (property.setter != null) _writeMethod(property.setter);
 
     if (property._provideFieldSyntax) {
       writer.enterBlock('Object.defineProperty(' +
         '${property.declaringType.jsname}.prototype, "${property.jsname}", {');
       if (property.getter != null) {
-        writer.writeln(
-          'get: ${property.declaringType.jsname}.prototype.${property.getter.jsname},');
+        writer.write(
+          'get: ${property.declaringType.jsname}.prototype.${property.getter.jsname}');
+        String endOfLine = '';
+        // The shenanigan below is to make IE happy -- IE 9 doesn't like a
+        // trailing comma on the last element in a list.
+        if (property.setter != null) {
+          endOfLine = ',';
+        }
+        writer.writeln(endOfLine);

[Siggi Cherem (dart-lang), 2011/11/10 23:04:37]

(nit): for this short logic, I prefer doing this in a single line, for instance:

// IE9 fails if there is a trailing comma
writer.writeln(property.setter == null ? '' : ',');

       }
       if (property.setter != null) {
         writer.writeln(
           'set: ${property.declaringType.jsname}.prototype.${property.setter.jsname}');
       }
       writer.exitBlock('});');
     }
   }
 
   _writeMethod(Member method) {
@@ skipping 1884 matching lines @@
       result.add(new Value(world.varType, '\$$i', false, /*needsTemp:*/false));
     }
     for (int i = bareCount; i < length; i++) {
       var name = getName(i);
       if (name == null) name = '\$$i';
       result.add(new Value(world.varType, name, false, /*needsTemp:*/false));
     }
     return new Arguments(nodes, result);
   }
 }