Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 8468029: Fix NWAura to use property to get restored bounds. (Closed)

Created:
9 years, 1 month ago by oshima
Modified:
9 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Fix NWAura to use property to get restored bounds. GetRestoredBounds should Return normal bounds if window is normal mode. BUG=103490 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110452

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : test fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -5 lines) Patch
M ui/aura/window.h View 2 chunks +0 lines, -4 lines 0 comments Download
M views/widget/native_widget_aura.cc View 1 chunk +3 lines, -1 line 0 comments Download
M views/widget/widget_unittest.cc View 1 2 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
oshima
I thought I fixed this when I moved the logic to shell, but apparently I ...
9 years, 1 month ago (2011-11-16 04:27:01 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-16 22:43:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8468029/3001
9 years, 1 month ago (2011-11-16 22:45:09 UTC) #3
commit-bot: I haz the power
Try job failure for 8468029-3001 (retry) on linux_rel for step "unit_tests". It's a second try, ...
9 years, 1 month ago (2011-11-16 23:55:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/8468029/3001
9 years, 1 month ago (2011-11-17 01:14:43 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-17 06:10:51 UTC) #6
Change committed as 110452

Powered by Google App Engine
This is Rietveld 408576698