Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: views/widget/widget_unittest.cc

Issue 8468029: Fix NWAura to use property to get restored bounds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test fix Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/widget/native_widget_aura.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/widget/widget_unittest.cc
diff --git a/views/widget/widget_unittest.cc b/views/widget/widget_unittest.cc
index 8af4526237b83cae80df6a758ee313107e7ab2c7..ab4f4997fa4b28cea847c91055180880ec003329 100644
--- a/views/widget/widget_unittest.cc
+++ b/views/widget/widget_unittest.cc
@@ -835,5 +835,34 @@ TEST_F(WidgetObserverTest, VisibilityChange) {
toplevel->CloseNow();
}
+#if !defined(USE_AURA) && defined(OS_WIN)
+// Aura needs shell to maximize/fullscreen window.
+// NativeWidgetGtk doesn't implement GetRestoredBounds.
+TEST_F(WidgetTest, GetRestoredBounds) {
+ Widget* toplevel = CreateTopLevelPlatformWidget();
+ EXPECT_EQ(toplevel->GetWindowScreenBounds().ToString(),
+ toplevel->GetRestoredBounds().ToString());
+ toplevel->Show();
+ toplevel->Maximize();
+ RunPendingMessages();
+ EXPECT_NE(toplevel->GetWindowScreenBounds().ToString(),
+ toplevel->GetRestoredBounds().ToString());
+ EXPECT_GT(toplevel->GetRestoredBounds().width(), 0);
+ EXPECT_GT(toplevel->GetRestoredBounds().height(), 0);
+
+ toplevel->Restore();
+ RunPendingMessages();
+ EXPECT_EQ(toplevel->GetWindowScreenBounds().ToString(),
+ toplevel->GetRestoredBounds().ToString());
+
+ toplevel->SetFullscreen(true);
+ RunPendingMessages();
+ EXPECT_NE(toplevel->GetWindowScreenBounds().ToString(),
+ toplevel->GetRestoredBounds().ToString());
+ EXPECT_GT(toplevel->GetRestoredBounds().width(), 0);
+ EXPECT_GT(toplevel->GetRestoredBounds().height(), 0);
+}
+#endif
+
} // namespace
} // namespace views
« no previous file with comments | « views/widget/native_widget_aura.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698