Issue 8468018: chrome: Remove 10 exit time destructors and 2 static initializers.

Issue 8468018: chrome: Remove 10 exit time destructors and 2 static initializers. (Closed)

Created:
9 years, 1 month ago by Nico

Modified:
9 years, 1 month ago

Reviewers:
Mark Mentovai, Aaron Boodman

CC:
chromium-reviews, Erik does not do reviews, mihaip+watch_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, jshin+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chrome: Remove 10 exit time destructors and 2 static initializers. version_extension_ in MetricsLogBase was only used in the MetricsLog subclass, so move it to there. BUG=101600, 94925 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110219

Patch Set 1 #

Patch Set 2 : duh #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -36 lines)			Patch
M	chrome/browser/metrics/metrics_log.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/metrics/metrics_log.cc	View		4 chunks	+17 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_file_util.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/common/extensions/extension_l10n_util.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/common/mac/objc_zombie.mm	View		6 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/common/metrics_helpers.h	View		3 chunks	+1 line, -9 lines	0 comments	Download
M	chrome/common/metrics_helpers.cc	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/profiling.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/time_format.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/extensions/schema_generated_bindings.cc	View		1 chunk	+2 lines, -4 lines	0 comments	Download
M	chrome/renderer/searchbox_extension.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Nico

aa: The change to GetValidLocales() in chrome/common/extensions/extension_l10n_util.cc. I believe the static in there is a ...

9 years, 1 month ago (2011-11-15 21:46:37 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8468018/2001

9 years, 1 month ago (2011-11-15 22:47:22 UTC) #4

Change committed as 110219

Expand Messages | Collapse Messages