Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3190)

Unified Diff: chrome/common/metrics_helpers.h

Issue 8468018: chrome: Remove 10 exit time destructors and 2 static initializers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: duh Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/mac/objc_zombie.mm ('k') | chrome/common/metrics_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/metrics_helpers.h
diff --git a/chrome/common/metrics_helpers.h b/chrome/common/metrics_helpers.h
index 74196dd2d16fab057feff7e94d29c7c3a7c00bb5..65c111d88e60110a7abb6b8b8f93a6f987f948e7 100644
--- a/chrome/common/metrics_helpers.h
+++ b/chrome/common/metrics_helpers.h
@@ -94,12 +94,6 @@ class MetricsLogBase {
// reliability stats, from other builds, can be abandoned.
static int64 GetBuildTime();
- // Use |extension| in all uploaded appversions in addition to the standard
- // version string.
- static void set_version_extension(const std::string& extension) {
- version_extension_ = extension;
- }
-
virtual MetricsLog* AsMetricsLog();
protected:
@@ -150,9 +144,6 @@ class MetricsLogBase {
// Write the attributes that are common to every metrics event type.
void WriteCommonEventAttributes();
- // An extension that is appended to the appversion in each log.
- static std::string version_extension_;
-
base::Time start_time_;
base::Time end_time_;
@@ -170,6 +161,7 @@ class MetricsLogBase {
int num_events_; // the number of events recorded in this log
+ private:
DISALLOW_COPY_AND_ASSIGN(MetricsLogBase);
};
« no previous file with comments | « chrome/common/mac/objc_zombie.mm ('k') | chrome/common/metrics_helpers.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698