Issue 8468010: Creation of cookie_utils.

Issue 8468010: Creation of cookie_utils. (Closed)

Created:
9 years, 1 month ago by droger_google

Modified:
9 years, 1 month ago

Reviewers:
erikwright (departed), wtc

CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), Erik does not do reviews, Paweł Hajdan Jr., wtc, mihaip+watch_chromium.org, Randy Smith (Not in Mondays), Aaron Boodman, darin-cc_chromium.org, rkn

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Creation of cookie_utils. BUG=NONE TEST=NONE Follow up on: Review URL: http://codereview.chromium.org/8465022 Then reverted by: http://codereview.chromium.org/8571008/ Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110476

Patch Set 1 #

Patch Set 2 : Added missing NET_EXPORT #

Patch Set 3 : Indentation #

Total comments: 2

Patch Set 4 : Review comments #

Total comments: 2

Patch Set 5 : Review comments again #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -84 lines)			Patch
M	chrome/browser/extensions/extension_cookies_helpers.cc	View	1 2 3	3 chunks	+4 lines, -3 lines	0 comments	Download
M	net/base/cookie_monster.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	net/base/cookie_monster.cc	View	1 2 3	8 chunks	+11 lines, -76 lines	0 comments	Download
M	net/base/cookie_monster_unittest.cc	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
A	net/base/cookie_util.h	View	1 2 3 4	1 chunk	+40 lines, -0 lines	0 comments	Download
A	net/base/cookie_util.cc	View	1 2 3	1 chunk	+79 lines, -0 lines	0 comments	Download
M	net/net.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

erikwright (departed)

http://codereview.chromium.org/8468010/diff/6001/net/base/cookie_utils.h File net/base/cookie_utils.h (right): http://codereview.chromium.org/8468010/diff/6001/net/base/cookie_utils.h#newcode19 net/base/cookie_utils.h:19: NET_EXPORT std::string GetEffectiveDomain(const std::string& scheme, I think you need: ...

9 years, 1 month ago (2011-11-15 18:14:27 UTC) #2

wtc

Review comments on Patch Set 3: http://codereview.chromium.org/8468010/diff/6001/net/base/cookie_utils.h File net/base/cookie_utils.h (right): http://codereview.chromium.org/8468010/diff/6001/net/base/cookie_utils.h#newcode14 net/base/cookie_utils.h:14: namespace cookie_utils { ...

9 years, 1 month ago (2011-11-16 06:34:31 UTC) #3

wtc

Patch Set 4 LGTM. Thanks. http://codereview.chromium.org/8468010/diff/8001/net/base/cookie_util.h File net/base/cookie_util.h (right): http://codereview.chromium.org/8468010/diff/8001/net/base/cookie_util.h#newcode6 net/base/cookie_util.h:6: #define NET_BASE_COOKIE_UTILS_H_ The header ...

9 years, 1 month ago (2011-11-17 03:01:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@google.com/8468010/14001

9 years, 1 month ago (2011-11-17 08:31:04 UTC) #7

Change committed as 110476

Expand Messages | Collapse Messages