Make sure only the right processes can access the profile path.

Make sure only the right processes can access the profile path.

This is especially important for windows because sandboxed processes
are blocked from accessng the profile directory if it is on network
shares.

BUG=84045
TEST=Chrome should start renderes if the profile dir is on roaming profile.

[pastarmovj, 2011-11-11 17:18:11]

Hey I splitted the two fixes in separate CLs would you take closer look at those
and possibly rubberstamp them for upload.

[Aaron Boodman, 2011-11-11 19:56:38]

LGTM

[pastarmovj, 2011-12-07 14:59:31]

As per the discussion on chromium-dev I solved the dependency of
crash_service_win64 by directly referencing the two files from
content/browser/public needed.

Are you still ok with this change then I will proceed with committing it to
trunk. Now we are far from the next branch point and there will be plenty of
time to do fine tuning of the allowed process list if needed.

[pastarmovj, 2011-12-09 13:36:09]

ping?

[Aaron Boodman, 2011-12-09 16:30:06]

still LGTM

[commit-bot: I haz the power, 2011-12-12 12:51:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/8463020/3001

[commit-bot: I haz the power, 2011-12-12 16:43:39]

Try job failure for 8463020-3001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[pastarmovj, 2011-12-19 18:15:22]

Hi guys,
sorry for bothering you again but I had to upload a new version of this CL to
satisfy the win_rel both which was constantly hanging on the old CL because for
some reason it didn't like not overriding the USER_DATA_DIR in some strange
cases. Anyway the new code always overrides that dir but only creates it from
processes that are allowed to do so. Therefore the change is contained in
chrome_main_delegate.cc
The only other change is that I renamed the function
CheckIfProccessNeedsProfileDir to ProccessNeedsProfileDir which tell everything
and is much shorter.

@Will: I will be happy to have owner approval for bsae/path_service.*. I had to
make a new version of Override that has a param telling it to create or not to
create the old syntax just redirects to the new one with the default value true
so that the semantic is only changed for the new invocations.

Thank you all!
-Julian


PS. Try bots have been run for this CL and seem to be fine with it links are
here:

http://chromegw.corp.google.com/i/tryserver.chromium/builders/win_rel/builds/...
http://chromegw.corp.google.com/i/tryserver.chromium/builders/linux_clang/bui...
http://chromegw.corp.google.com/i/tryserver.chromium/builders/linux/builds/7480
http://chromegw.corp.google.com/i/tryserver.chromium/builders/mac/builds/7373
http://chromegw.corp.google.com/i/tryserver.chromium/builders/win/builds/7824

[willchan no longer on Chromium, 2011-12-19 23:29:14]

Sick, redirecting to brettw.

[pastarmovj, 2011-12-21 16:52:03]

On 2011/12/19 23:29:14, willchan wrote:
> Sick, redirecting to brettw.

Ping?

[brettw, 2011-12-21 18:40:52]

Can you give some background on what you're trying to achieve and what project
this is part of? I though we weren't supporting things like roaming profiles.

[Glenn Wilson, 2011-12-21 19:07:27]

On 2011/12/21 18:40:52, brettw wrote:
> Can you give some background on what you're trying to achieve and what project
> this is part of? I though we weren't supporting things like roaming profiles.

The 'TEST' line is somewhat inaccurate IMHO.  The goal is to be able to run
Chrome with a profile that is on a network location.  This works on Win XP SP3,
but not Vista or Win 7.

This is not intended to add "true" support for roaming profiles, since it does
not solve the backwards-incompatibility of profile versions, so the 'TEST' line
isn't quite accurate.  However, many orgs want to be able to run it off of a
profile that is symlinked/on a network share without having the renderer hang.

[brettw, 2011-12-21 19:14:39]

On Wed, Dec 21, 2011 at 11:07 AM,  <gwilson@chromium.org> wrote:
> On 2011/12/21 18:40:52, brettw wrote:
>>
>> Can you give some background on what you're trying to achieve and what
>> project
>> this is part of? I though we weren't supporting things like roaming
>> profiles.
>
>
> The 'TEST' line is somewhat inaccurate IMHO.  The goal is to be able to run
> Chrome with a profile that is on a network location.  This works on Win XP
> SP3,
> but not Vista or Win 7.
>
> This is not intended to add "true" support for roaming profiles, since it
> does
> not solve the backwards-incompatibility of profile versions, so the 'TEST'
> line
> isn't quite accurate.  However, many orgs want to be able to run it off of a
> profile that is symlinked/on a network share without having the renderer
> hang.

Glen: can you talk to me & Carlos sometime?

Brett

[Glenn Wilson, 2011-12-22 17:00:01]

On 2011/12/21 19:14:39, brettw wrote:
> On Wed, Dec 21, 2011 at 11:07 AM,  <mailto:gwilson@chromium.org> wrote:
> > On 2011/12/21 18:40:52, brettw wrote:
> >>
> >> Can you give some background on what you're trying to achieve and what
> >> project
> >> this is part of? I though we weren't supporting things like roaming
> >> profiles.
> >
> >
> > The 'TEST' line is somewhat inaccurate IMHO. &nbsp;The goal is to be able to
run
> > Chrome with a profile that is on a network location. &nbsp;This works on Win
XP
> > SP3,
> > but not Vista or Win 7.
> >
> > This is not intended to add "true" support for roaming profiles, since it
> > does
> > not solve the backwards-incompatibility of profile versions, so the 'TEST'
> > line
> > isn't quite accurate. &nbsp;However, many orgs want to be able to run it off
of a
> > profile that is symlinked/on a network share without having the renderer
> > hang.
> 
> Glen: can you talk to me & Carlos sometime?
> 
> Brett

Certainly, will do.  I suspect you're both out for the holidays so I will try to
catch you after the new year...

[Glenn Wilson, 2012-01-03 19:51:20]

On 2011/12/22 17:00:01, Glenn Wilson wrote:
> On 2011/12/21 19:14:39, brettw wrote:
> > On Wed, Dec 21, 2011 at 11:07 AM,  <mailto:gwilson@chromium.org> wrote:
> > > On 2011/12/21 18:40:52, brettw wrote:
> > >>
> > >> Can you give some background on what you're trying to achieve and what
> > >> project
> > >> this is part of? I though we weren't supporting things like roaming
> > >> profiles.
> > >
> > >
> > > The 'TEST' line is somewhat inaccurate IMHO. &nbsp;The goal is to be able
to
> run
> > > Chrome with a profile that is on a network location. &nbsp;This works on
Win
> XP
> > > SP3,
> > > but not Vista or Win 7.
> > >
> > > This is not intended to add "true" support for roaming profiles, since it
> > > does
> > > not solve the backwards-incompatibility of profile versions, so the 'TEST'
> > > line
> > > isn't quite accurate. &nbsp;However, many orgs want to be able to run it
off
> of a
> > > profile that is symlinked/on a network share without having the renderer
> > > hang.
> > 
> > Glen: can you talk to me & Carlos sometime?
> > 
> > Brett
> 
> Certainly, will do.  I suspect you're both out for the holidays so I will try
to
> catch you after the new year...

Chatted briefly with Brett and Carlos, here's what needs to be added:

- after the profile is open, a check should be made to see if the profile is on
a network location.
- if chrome is running with a profile on a network location:
  - check if we are running in a citrix environment.
  - if chrome is *not* running in a citrix environment, but the profile is on a
network location, show a messagebox warning alerting the user that chrome will
not function properly with a profile on a network location.
  - Also: add a command-line flag that disables this warning.  If this flag is
present, the warning is not shown.

(Brett/Carlos, correct me if I missed anything there.)

[pastarmovj, 2012-01-17 17:01:32]

On 2012/01/03 19:51:20, Glenn Wilson wrote:
> On 2011/12/22 17:00:01, Glenn Wilson wrote:
> > On 2011/12/21 19:14:39, brettw wrote:
> > > On Wed, Dec 21, 2011 at 11:07 AM,  <mailto:gwilson@chromium.org> wrote:
> > > > On 2011/12/21 18:40:52, brettw wrote:
> > > >>
> > > >> Can you give some background on what you're trying to achieve and what
> > > >> project
> > > >> this is part of? I though we weren't supporting things like roaming
> > > >> profiles.
> > > >
> > > >
> > > > The 'TEST' line is somewhat inaccurate IMHO. &nbsp;The goal is to be
able
> to
> > run
> > > > Chrome with a profile that is on a network location. &nbsp;This works on
> Win
> > XP
> > > > SP3,
> > > > but not Vista or Win 7.
> > > >
> > > > This is not intended to add "true" support for roaming profiles, since
it
> > > > does
> > > > not solve the backwards-incompatibility of profile versions, so the
'TEST'
> > > > line
> > > > isn't quite accurate. &nbsp;However, many orgs want to be able to run it
> off
> > of a
> > > > profile that is symlinked/on a network share without having the renderer
> > > > hang.
> > > 
> > > Glen: can you talk to me & Carlos sometime?
> > > 
> > > Brett
> > 
> > Certainly, will do.  I suspect you're both out for the holidays so I will
try
> to
> > catch you after the new year...
> 
> Chatted briefly with Brett and Carlos, here's what needs to be added:
> 
> - after the profile is open, a check should be made to see if the profile is
on
> a network location.
> - if chrome is running with a profile on a network location:
>   - check if we are running in a citrix environment.
>   - if chrome is *not* running in a citrix environment, but the profile is on
a
> network location, show a messagebox warning alerting the user that chrome will
> not function properly with a profile on a network location.
>   - Also: add a command-line flag that disables this warning.  If this flag is
> present, the warning is not shown.
> 
> (Brett/Carlos, correct me if I missed anything there.)

Hey, guys,
Happy New Year!

Following the latest discussion here I added user notification for all users
running chrome from a local console warning them when their profile is on a
network share or other location that has no reparse-point free path. I haven't
yet added command line flag to disable this warning but that will be
straightforward and I wanted to get your agreement on the notification
implementation first.
-Julian

[pastarmovj, 2012-01-23 13:38:58]

ping?

[Aaron Boodman, 2012-01-24 22:46:34]

I'm leaving this review to Brett/Carlos.