Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 8463012: Run more tests on the Webkit Layout Valgrind bot and do it in parallel (Closed)

Created:
9 years, 1 month ago by Timur Iskhodzhanov
Modified:
9 years, 1 month ago
Reviewers:
Lei Zhang, ojan
CC:
chromium-reviews, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Run more tests on the Webkit Layout Valgrind bot and do it in parallel Some numbers: with --experimental-fully-parallel my Z600 (16 threads) runs 360 tests in 30 minutes. The bot has 4 vcores, we may ask for more if it becomes too slow. I haven't seen any test failures locally; probably thanks to --run-singly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M tools/valgrind/chrome_tests.py View 2 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Timur Iskhodzhanov
9 years, 1 month ago (2011-11-11 12:42:34 UTC) #1
Lei Zhang
LGTM ojan: how "experimental" is --experimental-fully-parallel ? Should we be using it?
9 years, 1 month ago (2011-11-11 22:29:08 UTC) #2
ojan
On 2011/11/11 22:29:08, Lei Zhang wrote: > LGTM > > ojan: how "experimental" is --experimental-fully-parallel ...
9 years, 1 month ago (2011-11-11 22:44:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/8463012/1
9 years, 1 month ago (2011-11-12 06:57:07 UTC) #4
commit-bot: I haz the power
Change committed as 109787
9 years, 1 month ago (2011-11-12 08:10:44 UTC) #5
Timur Iskhodzhanov
9 years, 1 month ago (2011-11-12 19:55:03 UTC) #6
FTR: As expected, the cycle time is now ~1h for 200 tests.
before the change, we were running 60 tests in ~40m on average.

btw, most of the tests pass :)

Powered by Google App Engine
This is Rietveld 408576698