Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: tools/valgrind/chrome_tests.py

Issue 8463012: Run more tests on the Webkit Layout Valgrind bot and do it in parallel (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/valgrind/chrome_tests.py
===================================================================
--- tools/valgrind/chrome_tests.py (revision 109598)
+++ tools/valgrind/chrome_tests.py (working copy)
@@ -350,8 +350,11 @@
os.makedirs(out_dir)
script = os.path.join(self._source_dir, "webkit", "tools", "layout_tests",
"run_webkit_tests.py")
- script_cmd = ["python", script, "--run-singly", "-v",
- "--noshow-results", "--time-out-ms=200000",
+ script_cmd = ["python", script, "-v",
+ "--run-singly", # run a separate DumpRenderTree for each test
+ "--experimental-fully-parallel",
+ "--time-out-ms=200000",
+ "--noshow-results",
"--nocheck-sys-deps"]
# Pass build mode to run_webkit_tests.py. We aren't passed it directly,
# so parse it out of build_dir. run_webkit_tests.py can only handle
@@ -482,11 +485,7 @@
"instead of /tmp.\nThis can be useful for tool "
"developers/maintainers.\nPlease note that the <tool>"
".logs directory will be clobbered on tool startup.")
- # My machine can do about 120 layout tests/hour in release mode.
- # Let's do 30 minutes worth per run.
- # The CPU is mostly idle, so perhaps we can raise this when
- # we figure out how to run them more efficiently.
- parser.add_option("-n", "--num_tests", default=60, type="int",
+ parser.add_option("-n", "--num_tests", default=200, type="int",
help="for layout tests: # of subtests per run. 0 for all.")
options, args = parser.parse_args()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698