Issue 8462018: Fix browser crash when viewing page info on certain popups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8462018: Fix browser crash when viewing page info on certain popups. (Closed)

Created:
9 years, 1 month ago by Finnur

Modified:
9 years, 1 month ago

Reviewers:
pfeldman

CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix browser crash when viewing page info on certain popups. A check for NULL NavigationEntry was removed when issue 91325 was fixed. This readds it. BUG=103453 TEST=Repro steps are in the bug, work reliably for me on W7. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109606

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/tab_contents/render_view_context_menu.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages