Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Unified Diff: chrome/browser/tab_contents/render_view_context_menu.cc

Issue 8462018: Fix browser crash when viewing page info on certain popups. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/tab_contents/render_view_context_menu.cc
===================================================================
--- chrome/browser/tab_contents/render_view_context_menu.cc (revision 109003)
+++ chrome/browser/tab_contents/render_view_context_menu.cc (working copy)
@@ -1044,11 +1044,11 @@
return source_tab_contents_->controller().CanViewSource();
case IDC_CONTENT_CONTEXT_INSPECTELEMENT:
- // Viewing page info is not a developer command but is meaningful for the
- // same set of pages which developer commands are meaningful for.
- case IDC_CONTENT_CONTEXT_VIEWPAGEINFO:
return IsDevCommandEnabled(id);
+ case IDC_CONTENT_CONTEXT_VIEWPAGEINFO:
+ return source_tab_contents_->controller().GetActiveEntry() != NULL;
+
case IDC_CONTENT_CONTEXT_TRANSLATE: {
TabContentsWrapper* tab_contents_wrapper =
TabContentsWrapper::GetCurrentWrapperForContents(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698