Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 8460004: generator.py must accept M17 (Closed)

Created:
9 years, 1 month ago by Takashi Toyoshima
Modified:
9 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

generator.py must accept M17 BUG=87310 TEST=n/a

Patch Set 1 #

Patch Set 2 : fix PRESUBMIT.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ppapi/PRESUBMIT.py View 1 2 chunks +1 line, -2 lines 0 comments Download
M ppapi/generators/generator.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Takashi Toyoshima
Hi Noel, I'd like to use M17 label for WebSocket Pepper API. ( See, http://codereview.chromium.org/8395037/ ...
9 years, 1 month ago (2011-11-04 05:50:39 UTC) #1
noelallen_use_chromium
LGTM
9 years, 1 month ago (2011-11-04 16:48:22 UTC) #2
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-04 16:49:26 UTC) #3
Takashi Toyoshima
OWNERS contains chromium address. Need LGTM from chromium account?
9 years, 1 month ago (2011-11-04 16:54:19 UTC) #4
noelallen1
LGTM
9 years, 1 month ago (2011-11-04 16:59:41 UTC) #5
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 1 month ago (2011-11-04 19:37:18 UTC) #6
Takashi Toyoshima
9 years, 1 month ago (2011-11-07 06:00:57 UTC) #7
Close this issue without landing because of the better change as follows.
http://codereview.chromium.org/8478005

Powered by Google App Engine
This is Rietveld 408576698