Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 8460001: Expose gles2 bgra extensions when GL_EXT_bgra is supported (Closed)

Created:
9 years, 1 month ago by piman
Modified:
9 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Expose gles2 bgra extensions when GL_EXT_bgra is supported BUG=None TEST=Aura + Webkit compositor + accelerated painting Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=108711

Patch Set 1 #

Total comments: 2

Patch Set 2 : move comment back to wher it belongs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 1 2 chunks +13 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
piman
9 years, 1 month ago (2011-11-04 00:36:14 UTC) #1
Ken Russell (switch to Gerrit)
Thanks, LGTM. One minor comment. http://codereview.chromium.org/8460001/diff/1/webkit/gpu/webgraphicscontext3d_in_process_impl.cc File webkit/gpu/webgraphicscontext3d_in_process_impl.cc (right): http://codereview.chromium.org/8460001/diff/1/webkit/gpu/webgraphicscontext3d_in_process_impl.cc#newcode1251 webkit/gpu/webgraphicscontext3d_in_process_impl.cc:1251: // doesn't support it). ...
9 years, 1 month ago (2011-11-04 01:18:57 UTC) #2
piman
http://codereview.chromium.org/8460001/diff/1/webkit/gpu/webgraphicscontext3d_in_process_impl.cc File webkit/gpu/webgraphicscontext3d_in_process_impl.cc (right): http://codereview.chromium.org/8460001/diff/1/webkit/gpu/webgraphicscontext3d_in_process_impl.cc#newcode1251 webkit/gpu/webgraphicscontext3d_in_process_impl.cc:1251: // doesn't support it). On 2011/11/04 01:18:58, kbr wrote: ...
9 years, 1 month ago (2011-11-04 01:36:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8460001/4001
9 years, 1 month ago (2011-11-04 01:36:52 UTC) #4
commit-bot: I haz the power
Try job failure for 8460001-4001 (retry) (retry) on win_rel for step "chrome_frame_net_tests" (clobber build). It's ...
9 years, 1 month ago (2011-11-04 04:06:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8460001/4001
9 years, 1 month ago (2011-11-04 06:08:59 UTC) #6
commit-bot: I haz the power
Try job failure for 8460001-4001 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
9 years, 1 month ago (2011-11-04 07:51:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8460001/4001
9 years, 1 month ago (2011-11-04 08:26:37 UTC) #8
commit-bot: I haz the power
Try job failure for 8460001-4001 (retry) on win_rel for step "chrome_frame_net_tests". It's a second try, ...
9 years, 1 month ago (2011-11-04 10:39:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/8460001/4001
9 years, 1 month ago (2011-11-04 19:42:53 UTC) #10
commit-bot: I haz the power
9 years, 1 month ago (2011-11-04 21:06:19 UTC) #11
Change committed as 108711

Powered by Google App Engine
This is Rietveld 408576698