Issue 8459001: Extract the certificate to use in the download protection pingback.

Issue 8459001: Extract the certificate to use in the download protection pingback. (Closed)

Created:
9 years, 1 month ago by Brian Ryner

Modified:
9 years, 1 month ago

Reviewers:
noelutz, mattm

CC:
chromium-reviews, Paweł Hajdan Jr., panayiotis

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Extract the certificate to use in the download protection pingback. Also sync the request protobuf with the server side, and make SignatureUtil mockable. BUG=102540 TEST=SignatureutilWinTest,DownloadProtectionServiceTest

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : Merge and fix test #

Total comments: 4

Patch Set 4 : Address Noe and Matt's comments #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+271 lines, -61 lines)			Patch
M	chrome/browser/safe_browsing/download_protection_service.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.cc	View	1 2 3	7 chunks	+16 lines, -11 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service_unittest.cc	View	1 2	10 chunks	+89 lines, -7 lines	0 comments	Download
M	chrome/browser/safe_browsing/signature_util.h	View	1 2	1 chunk	+20 lines, -5 lines	0 comments	Download
M	chrome/browser/safe_browsing/signature_util_posix.cc	View	1 2	1 chunk	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/safe_browsing/signature_util_win.cc	View	1 2 3	1 chunk	+103 lines, -15 lines	0 comments	Download
M	chrome/browser/safe_browsing/signature_util_win_unittest.cc	View	1 2	2 chunks	+27 lines, -6 lines	0 comments	Download
M	chrome/common/safe_browsing/csd.proto	View	1 2	1 chunk	+5 lines, -12 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

noelutz

lgtm nicely done! noé. http://codereview.chromium.org/8459001/diff/10001/chrome/browser/safe_browsing/download_protection_service.cc File chrome/browser/safe_browsing/download_protection_service.cc (right): http://codereview.chromium.org/8459001/diff/10001/chrome/browser/safe_browsing/download_protection_service.cc#newcode230 chrome/browser/safe_browsing/download_protection_service.cc:230: is_signed = false; nit: I ...

9 years, 1 month ago (2011-11-04 04:41:11 UTC) #2

mattm

lgtm http://codereview.chromium.org/8459001/diff/10001/chrome/browser/safe_browsing/signature_util_win.cc File chrome/browser/safe_browsing/signature_util_win.cc (right): http://codereview.chromium.org/8459001/diff/10001/chrome/browser/safe_browsing/signature_util_win.cc#newcode8 chrome/browser/safe_browsing/signature_util_win.cc:8: #include <wincrypt.h> nit: missing blank line

9 years, 1 month ago (2011-11-04 22:14:18 UTC) #3

Brian Ryner

http://codereview.chromium.org/8459001/diff/10001/chrome/browser/safe_browsing/download_protection_service.cc File chrome/browser/safe_browsing/download_protection_service.cc (right): http://codereview.chromium.org/8459001/diff/10001/chrome/browser/safe_browsing/download_protection_service.cc#newcode230 chrome/browser/safe_browsing/download_protection_service.cc:230: is_signed = false; On 2011/11/04 04:41:11, noelutz wrote: > ...

9 years, 1 month ago (2011-11-04 22:20:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/8459001/16001

9 years, 1 month ago (2011-11-04 22:54:40 UTC) #5

Change committed as 108747

Expand Messages | Collapse Messages