Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: chrome/common/safe_browsing/csd.proto

Issue 8459001: Extract the certificate to use in the download protection pingback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Address Noe and Matt's comments Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/safe_browsing/signature_util_win_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Client side phishing and malware detection request and response 5 // Client side phishing and malware detection request and response
6 // protocol buffers. Those protocol messages should be kept in sync 6 // protocol buffers. Those protocol messages should be kept in sync
7 // with the server implementation. 7 // with the server implementation.
8 // 8 //
9 // If you want to change this protocol definition or you have questions 9 // If you want to change this protocol definition or you have questions
10 // regarding its format please contact chrome-anti-phishing@googlegroups.com. 10 // regarding its format please contact chrome-anti-phishing@googlegroups.com.
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 118
119 // TODO(noelutz): add the transition type? 119 // TODO(noelutz): add the transition type?
120 } 120 }
121 121
122 // This repeated field will store all the redirects as well as the 122 // This repeated field will store all the redirects as well as the
123 // final URLs for the top-level tab URL (i.e., the URL that 123 // final URLs for the top-level tab URL (i.e., the URL that
124 // triggered the download) as well as for the download URL itself. 124 // triggered the download) as well as for the download URL itself.
125 repeated Resource resources = 4; 125 repeated Resource resources = 4;
126 126
127 message SignatureInfo { 127 message SignatureInfo {
128 // If the binary is signed this will contain the name of the certificate 128 // The full DER-encoded X.509 certificate extracted from the binary.
129 // authority that signed the binary. The format of that field is TBD. 129 // If this field is not present, it means the binary was unsigned.
130 optional bytes certificate_issuer = 1; 130 optional bytes certificate_contents = 1;
131 131
132 // Serial number of the certificate autority. This value uniquely 132 // True if the signature was trusted on the client.
133 // identifies the certificate authority. 133 optional bool trusted = 2;
134 optional bytes certificate_serial_number = 2;
135
136 // Name of the company / organization the ceritificate was issued to.
137 optional bytes certificate_subject = 3;
138
139 // The full DER-encoded X.509 certificate extracted from the binary.
140 optional bytes certificate_contents = 4;
141 } 134 }
142 135
143 // This field will only be set if the binary is signed. 136 // This field will only be set if the binary is signed.
144 optional SignatureInfo signature = 5; 137 optional SignatureInfo signature = 5;
145 138
146 // True if the download was user initiated. 139 // True if the download was user initiated.
147 optional bool user_initiated = 6; 140 optional bool user_initiated = 6;
148 } 141 }
149 142
150 message ClientDownloadResponse { 143 message ClientDownloadResponse {
151 enum Verdict { 144 enum Verdict {
152 // Download is considered safe. 145 // Download is considered safe.
153 SAFE = 0; 146 SAFE = 0;
154 // Download is considered dangerous. Chrome should show a warning to the 147 // Download is considered dangerous. Chrome should show a warning to the
155 // user. 148 // user.
156 DANGEROUS = 1; 149 DANGEROUS = 1;
157 } 150 }
158 required Verdict verdict = 1; 151 required Verdict verdict = 1;
159 } 152 }
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/signature_util_win_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698