Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: frog/presubmit.py

Issue 8457007: Better runtime type checks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: cleaner output Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: frog/presubmit.py
diff --git a/frog/presubmit.py b/frog/presubmit.py
index 135858aee499fb3107e2094edfc8192c55cb6e50..617fbef043c28ef818df510be8477f32038064df 100755
--- a/frog/presubmit.py
+++ b/frog/presubmit.py
@@ -51,24 +51,30 @@ def main(args):
"""Adds ANSI escape-code for bold-face"""
return "\033[1m%s\033[0m" % s
+ # VM Checked, produces checked
print 'Started'
start = time.time()
RunCommand('./frog.py',
'--vm_flags=--compile_all --enable_type_checks --enable_asserts',
- '--', '--out=frogsh', 'frog.dart')
+ '--', '--enable_type_checks', '--out=frogsh', 'frog.dart')
elapsed = time.time() - start
print 'Compiling on Dart VM took %s seconds %s' % (b(elapsed),
b('in checked mode'))
+
+ # VM Normal, produces checked
start = time.time()
- RunCommand('./frog.py', '--out=frogsh', 'frog.dart')
+ RunCommand('./frog.py', '--out=frogsh', '--enable_type_checks', 'frog.dart')
elapsed = time.time() - start
print 'Compiling on Dart VM took %s seconds' % b(elapsed)
+
+ # Selfhost Checked
Jennifer Messerly 2011/11/05 00:45:11 The speed/size is reasonable enough, so I just tur
start = time.time()
- RunCommand('./frogsh', '--out=frogsh', 'frog.dart', 'tests/hello.dart')
+ RunCommand('./frogsh', '--out=frogsh', '--enable_type_checks', 'frog.dart',
+ '--enable_type_checks', 'tests/hello.dart')
elapsed = time.time() - start
size = os.path.getsize('./frogsh') / 1024
- print 'Bootstrapping took %s seconds' % b(elapsed)
- print 'Generated frogsh is \033[1m%d\033[0m kB' % size
+ print 'Bootstrapping took %s seconds %s' % (b(elapsed), b('in checked mode'))
+ print 'Generated %s frogsh is %s kB' % (b('checked'), b(size))
RunCommand('../tools/build.py', '--mode=release')
test_cmd = ['../tools/test.py', '--component=frog,frogsh,leg',
« frog/parser.dart ('K') | « frog/parser.dart ('k') | frog/scripts/token_info.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698